Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 182853002: Replace use of GC::alpha() in SVGImage::draw() with GC::getNormalizedAlpha() (Closed)

Created:
6 years, 9 months ago by fs
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, ed+blinkwatch_opera.com, Rik, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Replace use of GC::alpha() in SVGImage::draw() with GC::getNormalizedAlpha() As requested in https://codereview.chromium.org/181633002/ BUG=261177 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168049

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/svg/graphics/SVGImage.cpp View 1 chunk +3 lines, -2 lines 2 comments Download
M Source/platform/graphics/GraphicsContext.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
fs
6 years, 9 months ago (2014-02-27 09:07:15 UTC) #1
f(malita)
LGTM. I was going to ask if we're planning to fix the wonky rounding in ...
6 years, 9 months ago (2014-02-27 13:23:36 UTC) #2
fs
https://codereview.chromium.org/182853002/diff/1/Source/core/svg/graphics/SVGImage.cpp File Source/core/svg/graphics/SVGImage.cpp (right): https://codereview.chromium.org/182853002/diff/1/Source/core/svg/graphics/SVGImage.cpp#newcode250 Source/core/svg/graphics/SVGImage.cpp:250: float opacity = context->getNormalizedAlpha() / 255.f; On 2014/02/27 13:23:37, ...
6 years, 9 months ago (2014-02-27 14:31:56 UTC) #3
fs
The CQ bit was checked by fs@opera.com
6 years, 9 months ago (2014-02-27 14:32:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/182853002/20001
6 years, 9 months ago (2014-02-27 14:32:19 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-27 15:50:55 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) blink_heap_unittests, blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, ...
6 years, 9 months ago (2014-02-27 15:50:56 UTC) #7
fs
On 2014/02/27 14:31:56, fs wrote: > https://codereview.chromium.org/182853002/diff/1/Source/core/svg/graphics/SVGImage.cpp > File Source/core/svg/graphics/SVGImage.cpp (right): > > https://codereview.chromium.org/182853002/diff/1/Source/core/svg/graphics/SVGImage.cpp#newcode250 > ...
6 years, 9 months ago (2014-02-27 15:54:05 UTC) #8
fs
The CQ bit was checked by fs@opera.com
6 years, 9 months ago (2014-02-27 15:54:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/182853002/1
6 years, 9 months ago (2014-02-27 15:55:01 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-02-27 19:53:35 UTC) #11
Message was sent while issue was closed.
Change committed as 168049

Powered by Google App Engine
This is Rietveld 408576698