Support packaging secondary abi native libraries in APK.

Support packaging secondary abi native libraries in APK.

BUG=594807
Committed: https://crrev.com/b6fa1bb99d858a511761e8625e2436846c88b440
Cr-Commit-Position: refs/heads/master@{#382917}

[michaelbai, 2016-03-22 21:39:53]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[michaelbai, 2016-03-22 21:40:08]

Description was changed from

==========
Support packaging secondary abi native libraries in APK.

BUG=594807
==========

to

==========
Support packaging secondary abi native libraries in APK.

BUG=594807
==========

[michaelbai, 2016-03-22 21:40:08]

michaelbai@chromium.org changed reviewers:
+ agrieve@chromium.org

[commit-bot: I haz the power, 2016-03-22 21:40:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1828523002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1828523002/1

[commit-bot: I haz the power, 2016-03-22 23:00:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-22 23:00:40]

Dry run: This issue passed the CQ dry run.

[agrieve, 2016-03-23 18:11:19]

just a couple nits. lgtm

https://codereview.chromium.org/1828523002/diff/1/build/android/gyp/apkbuilde...
File build/android/gyp/apkbuilder.py (right):

https://codereview.chromium.org/1828523002/diff/1/build/android/gyp/apkbuilde...
build/android/gyp/apkbuilder.py:55: help='The libraries for secondary
android-abi. '
You should say that this is a GYP-list

https://codereview.chromium.org/1828523002/diff/1/build/config/android/config...
File build/config/android/config.gni (right):

https://codereview.chromium.org/1828523002/diff/1/build/config/android/config...
build/config/android/config.gni:235: # Intentionally not define
android_app_secondary_abi for 64-bit
nit: "Intentionally not define" -> "Intentionally do not define

[michaelbai, 2016-03-23 18:55:33]

https://codereview.chromium.org/1828523002/diff/1/build/android/gyp/apkbuilde...
File build/android/gyp/apkbuilder.py (right):

https://codereview.chromium.org/1828523002/diff/1/build/android/gyp/apkbuilde...
build/android/gyp/apkbuilder.py:55: help='The libraries for secondary
android-abi. '
On 2016/03/23 18:11:19, agrieve wrote:
> You should say that this is a GYP-list

Done.

https://codereview.chromium.org/1828523002/diff/1/build/config/android/config...
File build/config/android/config.gni (right):

https://codereview.chromium.org/1828523002/diff/1/build/config/android/config...
build/config/android/config.gni:235: # Intentionally not define
android_app_secondary_abi for 64-bit
On 2016/03/23 18:11:19, agrieve wrote:
> nit: "Intentionally not define" -> "Intentionally do not define 

Done.

[michaelbai, 2016-03-23 18:56:27]

The CQ bit was checked by michaelbai@chromium.org

[michaelbai, 2016-03-23 18:56:28]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/1828523002/#ps20001
(title: "address comment")

[commit-bot: I haz the power, 2016-03-23 18:56:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1828523002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1828523002/20001

[commit-bot: I haz the power, 2016-03-23 20:35:46]

Description was changed from

==========
Support packaging secondary abi native libraries in APK.

BUG=594807
==========

to

==========
Support packaging secondary abi native libraries in APK.

BUG=594807
==========

[commit-bot: I haz the power, 2016-03-23 20:35:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-23 20:37:42]

Description was changed from

==========
Support packaging secondary abi native libraries in APK.

BUG=594807
==========

to

==========
Support packaging secondary abi native libraries in APK.

BUG=594807

Committed: https://crrev.com/b6fa1bb99d858a511761e8625e2436846c88b440
Cr-Commit-Position: refs/heads/master@{#382917}
==========

[commit-bot: I haz the power, 2016-03-23 20:37:43]

Patchset 2 (id:??) landed as
https://crrev.com/b6fa1bb99d858a511761e8625e2436846c88b440
Cr-Commit-Position: refs/heads/master@{#382917}