OLD | NEW |
1 # Copyright 2014 The Chromium Authors. All rights reserved. | 1 # Copyright 2014 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 import("//tools/grit/grit_rule.gni") | 5 import("//tools/grit/grit_rule.gni") |
6 import("//build/config/nacl/config.gni") | 6 import("//build/config/nacl/config.gni") |
7 | 7 |
8 # Applied by targets internal to content. | 8 # Applied by targets internal to content. |
9 config("content_implementation") { | 9 config("content_implementation") { |
10 defines = [ "CONTENT_IMPLEMENTATION" ] | 10 defines = [ "CONTENT_IMPLEMENTATION" ] |
(...skipping 19 matching lines...) Expand all Loading... |
30 # //content (shared library) -> | 30 # //content (shared library) -> |
31 # //content/public/browser:browser_sources (source set) -> | 31 # //content/public/browser:browser_sources (source set) -> |
32 # //content/browser (source set; this is the non-public browser target) | 32 # //content/browser (source set; this is the non-public browser target) |
33 # //content/public/common:common_sources (source set) | 33 # //content/public/common:common_sources (source set) |
34 # | 34 # |
35 # That the internal content dependencies must depend on the *_sources targets | 35 # That the internal content dependencies must depend on the *_sources targets |
36 # to avoid dependency cycles, and external dependencies must depend on the | 36 # to avoid dependency cycles, and external dependencies must depend on the |
37 # //content/public/browser and similar targets to avoid double-linking (these | 37 # //content/public/browser and similar targets to avoid double-linking (these |
38 # targets make sure the dependency goes through the content shared library | 38 # targets make sure the dependency goes through the content shared library |
39 # when doing a component build). | 39 # when doing a component build). |
| 40 # |
| 41 # TESTS |
| 42 # ----- |
| 43 # Tests are a challenge. The content tests need to access internals of |
| 44 # content/browser, for example, but the tests themselves are outside of the |
| 45 # content component (which is a shared library in the component build). To |
| 46 # prevent external-to-content targets from depending on private headers, |
| 47 # the non-public content/browser target is not a public dep of the content |
| 48 # component. But this means there is also no public path for the content |
| 49 # tests and no way to restrict that just to //content/test/* if we added one. |
| 50 # |
| 51 # As a result, we check deps for //content/test/* only in non-component builds |
| 52 # (which should verify the dependencies are correct for both component and |
| 53 # non-component cases equally). There are targets like |
| 54 # //content/browser:for_content_tests that allow content/test to depend on the |
| 55 # //content/browser target only in non-component builds (when there are no |
| 56 # linking problems) for when check is enabled. |
40 | 57 |
41 if (!is_nacl_nonsfi) { | 58 if (!is_nacl_nonsfi) { |
42 content_shared_components = [ | 59 content_shared_components = [ |
43 "//content/gpu:gpu_sources", | 60 "//content/gpu:gpu_sources", |
44 "//content/public/browser:browser_sources", | 61 "//content/public/browser:browser_sources", |
45 "//content/public/child:child_sources", | 62 "//content/public/child:child_sources", |
46 "//content/public/gpu:gpu_sources", | 63 "//content/public/gpu:gpu_sources", |
47 "//content/public/common:common_sources", | 64 "//content/public/common:common_sources", |
48 "//content/public/plugin:plugin_sources", | 65 "//content/public/plugin:plugin_sources", |
49 "//content/public/renderer:renderer_sources", | 66 "//content/public/renderer:renderer_sources", |
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
113 sources = [ | 130 sources = [ |
114 "app/sandbox_helper_win.cc", | 131 "app/sandbox_helper_win.cc", |
115 "public/app/sandbox_helper_win.h", | 132 "public/app/sandbox_helper_win.h", |
116 ] | 133 ] |
117 | 134 |
118 deps = [ | 135 deps = [ |
119 "//sandbox", | 136 "//sandbox", |
120 ] | 137 ] |
121 } | 138 } |
122 } | 139 } |
OLD | NEW |