Content "gn check" work.

Content "gn check" work.

Make content/gpu and content/plugin pass GN check.

Makes most of content/shell and content/test pass check. These are not all enabled yet pending a few remaining issues that are more difficult to solve.

The private content targets now allow content/test to include headers from them for non-component builds. Checking is disabled for content/test in component builds as described in the comment at the top of //content/BUILD.gn

Renames the ui/events/ipc according to GN style

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jschuh (IPC build tweak)

Committed: https://crrev.com/f510be61306f5e4986eceb1f8686bfcc934cd400
Cr-Commit-Position: refs/heads/master@{#383208}

[brettw, 2016-03-22 20:30:58]

Description was changed from

==========
Content "gn check" work.

Make content/gpu pass GN check.

Makes most of content/shell and content/test pass check. These are not
enabled yet pending a few remaining issues that are more difficult to solve.

Renames the ui/events/ipc according to GN style

BUG=
==========

to

==========
Content "gn check" work.

Make content/gpu pass GN check.

Makes most of content/shell and content/test pass check. These are not
enabled yet pending a few remaining issues that are more difficult to solve.

Renames the ui/events/ipc according to GN style

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[brettw, 2016-03-22 20:31:50]

Description was changed from

==========
Content "gn check" work.

Make content/gpu pass GN check.

Makes most of content/shell and content/test pass check. These are not
enabled yet pending a few remaining issues that are more difficult to solve.

Renames the ui/events/ipc according to GN style

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Content "gn check" work.

Make content/gpu and content/plugin pass GN check.

Makes most of content/shell and content/test pass check. These are not
enabled yet pending a few remaining issues that are more difficult to solve.

Renames the ui/events/ipc according to GN style

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[brettw, 2016-03-22 20:32:47]

Description was changed from

==========
Content "gn check" work.

Make content/gpu and content/plugin pass GN check.

Makes most of content/shell and content/test pass check. These are not
enabled yet pending a few remaining issues that are more difficult to solve.

Renames the ui/events/ipc according to GN style

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Content "gn check" work.

Make content/gpu and content/plugin pass GN check.

Makes most of content/shell and content/test pass check. These are not enabled
yet pending a few remaining issues that are more difficult to solve.

The private content targets now allow content/test to include headers from them.
Unfortunately, the test targets are for everything and aren't broken up,
necessitating this style.

Renames the ui/events/ipc according to GN style

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[brettw, 2016-03-22 20:33:30]

brettw@chromium.org changed reviewers:
+ jam@chromium.org

[brettw, 2016-03-22 21:10:34]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-22 21:11:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1828483002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1828483002/1

[commit-bot: I haz the power, 2016-03-22 21:13:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-22 21:13:26]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jam, 2016-03-22 22:18:58]

lgtm

[brettw, 2016-03-22 23:52:40]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-03-22 23:52:40]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1828483002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-03-22 23:52:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1828483002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1828483002/20001

[commit-bot: I haz the power, 2016-03-22 23:57:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-22 23:57:50]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[brettw, 2016-03-24 18:22:43]

app

[brettw, 2016-03-24 18:27:48]

utility

[brettw, 2016-03-24 18:27:57]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 18:28:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1828483002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1828483002/120001

[brettw, 2016-03-24 18:28:39]

Description was changed from

==========
Content "gn check" work.

Make content/gpu and content/plugin pass GN check.

Makes most of content/shell and content/test pass check. These are not enabled
yet pending a few remaining issues that are more difficult to solve.

The private content targets now allow content/test to include headers from them.
Unfortunately, the test targets are for everything and aren't broken up,
necessitating this style.

Renames the ui/events/ipc according to GN style

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Content "gn check" work.

Make content/gpu and content/plugin pass GN check.

Makes most of content/shell and content/test pass check. These are not all
enabled yet pending a few remaining issues that are more difficult to solve.

The private content targets now allow content/test to include headers from them
for non-component builds. Checking is disabled for content/test in component
builds as described in the comment at the top of //content/BUILD.gn

Renames the ui/events/ipc according to GN style

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-03-24 18:33:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 18:33:29]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[brettw, 2016-03-24 19:02:26]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-03-24 19:02:27]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1828483002/#ps120001
(title: "utility")

[brettw, 2016-03-24 19:02:44]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-03-24 19:02:44]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1828483002/#ps140001
(title: " ")

[commit-bot: I haz the power, 2016-03-24 19:02:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1828483002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1828483002/140001

[commit-bot: I haz the power, 2016-03-24 19:08:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 19:08:40]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[brettw, 2016-03-24 20:14:34]

visibility

[brettw, 2016-03-24 20:14:36]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-03-24 20:14:36]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1828483002/#ps160001
(title: "visibility")

[commit-bot: I haz the power, 2016-03-24 20:15:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1828483002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1828483002/160001

[commit-bot: I haz the power, 2016-03-24 20:22:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 20:22:45]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[brettw, 2016-03-24 23:27:58]

fixes

[brettw, 2016-03-24 23:27:59]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-03-24 23:28:00]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1828483002/#ps180001
(title: "fixes")

[commit-bot: I haz the power, 2016-03-24 23:28:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1828483002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1828483002/180001

[brettw, 2016-03-24 23:37:52]

Description was changed from

==========
Content "gn check" work.

Make content/gpu and content/plugin pass GN check.

Makes most of content/shell and content/test pass check. These are not all
enabled yet pending a few remaining issues that are more difficult to solve.

The private content targets now allow content/test to include headers from them
for non-component builds. Checking is disabled for content/test in component
builds as described in the comment at the top of //content/BUILD.gn

Renames the ui/events/ipc according to GN style

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Content "gn check" work.

Make content/gpu and content/plugin pass GN check.

Makes most of content/shell and content/test pass check. These are not all
enabled yet pending a few remaining issues that are more difficult to solve.

The private content targets now allow content/test to include headers from them
for non-component builds. Checking is disabled for content/test in component
builds as described in the comment at the top of //content/BUILD.gn

Renames the ui/events/ipc according to GN style

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jschuh (IPC build tweak)
==========

[brettw, 2016-03-24 23:37:52]

brettw@chromium.org changed reviewers:
+ jschuh@chromium.org

[commit-bot: I haz the power, 2016-03-25 00:41:25]

Description was changed from

==========
Content "gn check" work.

Make content/gpu and content/plugin pass GN check.

Makes most of content/shell and content/test pass check. These are not all
enabled yet pending a few remaining issues that are more difficult to solve.

The private content targets now allow content/test to include headers from them
for non-component builds. Checking is disabled for content/test in component
builds as described in the comment at the top of //content/BUILD.gn

Renames the ui/events/ipc according to GN style

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jschuh (IPC build tweak)
==========

to

==========
Content "gn check" work.

Make content/gpu and content/plugin pass GN check.

Makes most of content/shell and content/test pass check. These are not all
enabled yet pending a few remaining issues that are more difficult to solve.

The private content targets now allow content/test to include headers from them
for non-component builds. Checking is disabled for content/test in component
builds as described in the comment at the top of //content/BUILD.gn

Renames the ui/events/ipc according to GN style

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jschuh (IPC build tweak)
==========

[commit-bot: I haz the power, 2016-03-25 00:41:27]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-03-25 00:43:05]

Description was changed from

==========
Content "gn check" work.

Make content/gpu and content/plugin pass GN check.

Makes most of content/shell and content/test pass check. These are not all
enabled yet pending a few remaining issues that are more difficult to solve.

The private content targets now allow content/test to include headers from them
for non-component builds. Checking is disabled for content/test in component
builds as described in the comment at the top of //content/BUILD.gn

Renames the ui/events/ipc according to GN style

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jschuh (IPC build tweak)
==========

to

==========
Content "gn check" work.

Make content/gpu and content/plugin pass GN check.

Makes most of content/shell and content/test pass check. These are not all
enabled yet pending a few remaining issues that are more difficult to solve.

The private content targets now allow content/test to include headers from them
for non-component builds. Checking is disabled for content/test in component
builds as described in the comment at the top of //content/BUILD.gn

Renames the ui/events/ipc according to GN style

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jschuh (IPC build tweak)

Committed: https://crrev.com/f510be61306f5e4986eceb1f8686bfcc934cd400
Cr-Commit-Position: refs/heads/master@{#383208}
==========

[commit-bot: I haz the power, 2016-03-25 00:43:07]

Patchset 10 (id:??) landed as
https://crrev.com/f510be61306f5e4986eceb1f8686bfcc934cd400
Cr-Commit-Position: refs/heads/master@{#383208}

[dcheng, 2016-03-25 03:47:22]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2016-03-25 03:47:23]

Any chance this could have broken the win x64 GN build?

https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29...

[Ken Rockot(use gerrit already), 2016-03-25 16:12:50]

On 2016/03/25 at 03:47:23, dcheng wrote:
> Any chance this could have broken the win x64 GN build?
> 
>
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29...

Seems likely

[brettw, 2016-03-25 16:51:58]

On 2016/03/25 16:12:50, Ken Rockot wrote:
> On 2016/03/25 at 03:47:23, dcheng wrote:
> > Any chance this could have broken the win x64 GN build?
> > 
> >
>
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29...
> 
> Seems likely

This file was just added in:
https://codereview.chromium.org/1745903002

[brettw, 2016-03-25 16:55:34]

A revert of this CL (patchset #10 id:180001) has been created in
https://codereview.chromium.org/1836533002/ by brettw@chromium.org.

The reason for reverting is: Broke
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29....