Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1828433002: wasm: hook module dump to run-tests.py (Closed)

Created:
4 years, 9 months ago by JF
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, Jakob Kummerow
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M tools/run-deopt-fuzzer.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/run-tests.py View 2 chunks +8 lines, -0 lines 0 comments Download
M tools/testrunner/local/execution.py View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/testrunner/objects/context.py View 4 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
JF
4 years, 9 months ago (2016-03-22 18:01:41 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1828433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1828433002/1
4 years, 9 months ago (2016-03-22 18:02:22 UTC) #3
JF
Adding fuzzer files using these flags in this CL: https://codereview.chromium.org/1826513002
4 years, 9 months ago (2016-03-22 18:20:27 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 18:24:53 UTC) #6
bradn
lgtm
4 years, 9 months ago (2016-03-22 20:01:58 UTC) #8
Michael Achenbach
Have you considered just using --extra-flags? I don't see the benefit of having extra config ...
4 years, 9 months ago (2016-03-23 15:33:38 UTC) #9
JF
4 years, 9 months ago (2016-03-23 19:30:52 UTC) #10
Ha I didn't know about this! Thanks, it's much simpler :-)

Closing this CL, I'll update instructions for the other.

Powered by Google App Engine
This is Rietveld 408576698