Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 1828223002: [wasm] Fix formal parameter count and parameter indexes in JS->wasm wrappers. (Closed)

Created:
4 years, 9 months ago by titzer
Modified:
4 years, 9 months ago
Reviewers:
bradnelson, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fix formal parameter count and parameter indexes in JS->wasm wrappers. R=jarin@chromium.org,bradnelson@chromium.org BUG= Committed: https://crrev.com/6a806a558158cbab55ad9a1a456942a7c509c810 Cr-Commit-Position: refs/heads/master@{#35056}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -5 lines) Patch
M src/compiler/wasm-compiler.cc View 2 chunks +8 lines, -5 lines 0 comments Download
A test/mjsunit/wasm/adapter-frame.js View 1 chunk +321 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
4 years, 9 months ago (2016-03-24 12:43:28 UTC) #1
Jarin
lgtm
4 years, 9 months ago (2016-03-24 13:16:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1828223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1828223002/1
4 years, 9 months ago (2016-03-24 13:22:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-24 13:24:04 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 13:24:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a806a558158cbab55ad9a1a456942a7c509c810
Cr-Commit-Position: refs/heads/master@{#35056}

Powered by Google App Engine
This is Rietveld 408576698