third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h - Issue 1828213002: CREDENTIAL: Implement the 'PasswordCredential(HTMLFormElement)' constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h

Issue 1828213002: CREDENTIAL: Implement the 'PasswordCredential(HTMLFormElement)' constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-basics.html ('K') | « third_party/WebKit/Source/core/html/FormAssociatedElement.h ('k') | third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp » ('j') | third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h

diff --git a/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h b/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h

index c34b11a1ca2e64b736a488e51ea54bb12110a0d2..763070caef94eca889a4566b7ff0185064588c48 100644

--- a/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h

+++ b/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h

@@ -17,15 +17,17 @@ namespace blink {

class FormData;

class FormDataOptions;

+class HTMLFormElement;

class PasswordCredentialData;

class WebPasswordCredential;

using CredentialPostBodyType = FormDataOrURLSearchParams;

-class PasswordCredential final : public Credential {

+class MODULES_EXPORT PasswordCredential final : public Credential {

DEFINE_WRAPPERTYPEINFO();

public:

static PasswordCredential* create(const PasswordCredentialData&, ExceptionState&);

+ static PasswordCredential* create(HTMLFormElement*, ExceptionState&);

static PasswordCredential* create(WebPasswordCredential*);

// PasswordCredential.idl