third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js - Issue 1828203005: Expose SPDY pushes in DevTools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js

Issue 1828203005: Expose SPDY pushes in DevTools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adjusted time interpolation to not scale outside of source range Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/inter_process_time_ticks_converter.cc ('K') | « third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js ('k') | third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js

index 4b95f1dcc8d0a8520e0c511dd46e5feffc6af50e..200bfdd06b1d8613e353cdf99adc0e85d44369ba 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js

@@ -251,7 +251,7 @@ WebInspector.NetworkOverview.prototype = {

var request = requests[i];

var band = this._bandId(request.connectionId);

var y = (band === -1) ? 0 : (band % this._numBands + 1);

- var timeRanges = WebInspector.RequestTimingView.calculateRequestTimeRanges(request);

+ var timeRanges = WebInspector.RequestTimingView.calculateRequestTimeRanges(request, this._calculator.minimumBoundary());

for (var j = 0; j < timeRanges.length; ++j) {

var type = timeRanges[j].name;

if (band !== -1 || type === WebInspector.RequestTimeRangeNames.Total)

@@ -268,6 +268,7 @@ WebInspector.NetworkOverview.prototype = {

drawLines(WebInspector.RequestTimeRangeNames.Connecting, "#FF9800");

drawLines(WebInspector.RequestTimeRangeNames.ServiceWorker, "#FF9800");

drawLines(WebInspector.RequestTimeRangeNames.ServiceWorkerPreparation, "#FF9800");

+ drawLines(WebInspector.RequestTimeRangeNames.Push, "#8CDBff");

drawLines(WebInspector.RequestTimeRangeNames.Proxy, "#A1887F");

drawLines(WebInspector.RequestTimeRangeNames.DNS, "#009688");

drawLines(WebInspector.RequestTimeRangeNames.SSL, "#9C27B0");