Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: net/spdy/spdy_stream_unittest.cc

Issue 1828203005: Expose SPDY pushes in DevTools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_stream_unittest.cc
diff --git a/net/spdy/spdy_stream_unittest.cc b/net/spdy/spdy_stream_unittest.cc
index 70bbc49e84dd3c840f821197c2d3194f6d58938f..5acb434a029d0deb0c76d891652d54df599ff730 100644
--- a/net/spdy/spdy_stream_unittest.cc
+++ b/net/spdy/spdy_stream_unittest.cc
@@ -316,12 +316,14 @@ TEST_P(SpdyStreamTest, PushedStream) {
spdy_util_.AddUrlToHeaderBlock(kStreamUrl, &request_headers);
stream.OnPushPromiseHeadersReceived(request_headers);
+ base::Time response_time = base::Time::Now();
+ base::TimeTicks first_byte_time = base::TimeTicks::Now();
// Send some basic response headers.
SpdyHeaderBlock response;
response[spdy_util_.GetStatusKey()] = "200";
response[spdy_util_.GetVersionKey()] = "OK";
- stream.OnInitialResponseHeadersReceived(
- response, base::Time::Now(), base::TimeTicks::Now());
+ stream.OnInitialResponseHeadersReceived(response, response_time,
+ first_byte_time);
// And some more headers.
// TODO(baranovich): not valid for HTTP 2.
@@ -335,6 +337,11 @@ TEST_P(SpdyStreamTest, PushedStream) {
StreamDelegateDoNothing delegate(stream.GetWeakPtr());
stream.SetDelegate(&delegate);
+ LoadTimingInfo load_timing_info;
+ EXPECT_TRUE(stream.GetLoadTimingInfo(&load_timing_info));
+ EXPECT_EQ(first_byte_time, load_timing_info.push_start);
+ EXPECT_TRUE(load_timing_info.push_end.is_null());
Bence 2016/03/25 14:42:54 Can you also test for push_end (at least that it's
+
base::RunLoop().RunUntilIdle();
EXPECT_EQ("200", delegate.GetResponseHeaderValue(spdy_util_.GetStatusKey()));

Powered by Google App Engine
This is Rietveld 408576698