Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 1828203005: Expose SPDY pushes in DevTools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
index 816b6c27c5d130742400d0e888a400fb0c71ea63..1eadb6eb1c15bf970ae33a45eeeba2e75741f3fb 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
@@ -336,6 +336,8 @@ WebInspector.NetworkDataGridNode.prototype = {
var request = this._request;
var initiator = request.initiatorInfo();
+ if (request.timing && request.timing.pushStart)
+ cell.appendChild(createTextNode(WebInspector.UIString("Push / ")));
switch (initiator.type) {
case WebInspector.NetworkRequest.InitiatorType.Parser:
cell.title = initiator.url + ":" + initiator.lineNumber;
@@ -364,9 +366,9 @@ WebInspector.NetworkDataGridNode.prototype = {
break;
default:
- cell.title = "";
+ cell.title = WebInspector.UIString("Other");
cell.classList.add("network-dim-cell");
- cell.setTextAndTitle(WebInspector.UIString("Other"));
+ cell.appendChild(createTextNode(WebInspector.UIString("Other")));
}
},
@@ -427,7 +429,7 @@ WebInspector.NetworkDataGridNode.prototype = {
_updateTimingGraph: function()
{
var calculator = this._parentView.calculator();
- var timeRanges = WebInspector.RequestTimingView.calculateRequestTimeRanges(this._request);
+ var timeRanges = WebInspector.RequestTimingView.calculateRequestTimeRanges(this._request, calculator.minimumBoundary());
var right = timeRanges[0].end;
var container = this._barAreaElement;

Powered by Google App Engine
This is Rietveld 408576698