Expose SPDY pushes in DevTools

content/common/inter_process_time_ticks_converter.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/inter_process_time_ticks_converter.h"
 
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 
 namespace content {
@@ skipping 34 matching lines @@
   DCHECK_EQ(local_upper_bound.value_,
             ToLocalTimeTicks(remote_upper_bound).value_);
   DCHECK_EQ(target_range, Convert(source_range));
 }
 
 LocalTimeTicks InterProcessTimeTicksConverter::ToLocalTimeTicks(
     const RemoteTimeTicks& remote_ms) const {
   // If input time is "null", return another "null" time.
   if (remote_ms.value_ == 0)
     return LocalTimeTicks(0);
-  DCHECK_LE(remote_lower_bound_, remote_ms.value_);
-  DCHECK_GE(remote_upper_bound_, remote_ms.value_);
+
   RemoteTimeDelta remote_delta = remote_ms - remote_lower_bound_;
+
+  // For remote times that fall outside of remote time range, apply just time
+  // offset and ignore scaling, so as to avoid extrapolation error for values
+  // long in the past.
+  if (remote_ms.value_ < remote_lower_bound_ ||
+      remote_upper_bound_ < remote_ms.value_) {
+    return LocalTimeTicks(local_base_time_ + remote_delta.value_);

[mmenke, 2016/03/28 18:04:54]

Shouldn't this be:

if (remote_ms.value_ < remote_lower_bound_)
  return LocalTimeTicks(local_base_time_ + remote_delta.value_);
if (remote_upper_bound_ < remote_ms.value_)
  return LocalTimeTicks(remote_ms - remove_upper_bound_ + local_upper_bound_);

Or you can still keep the second DCHECK, instead of the second condition -
remove upper bound is calculated immediately before sending the IPC, so no times
should be in front of it.

+  }
   return LocalTimeTicks(local_base_time_ +
                         ToLocalTimeDelta(remote_delta).value_);
 }
 
 LocalTimeDelta InterProcessTimeTicksConverter::ToLocalTimeDelta(
     const RemoteTimeDelta& remote_delta) const {
   DCHECK_GE(remote_upper_bound_, remote_lower_bound_ + remote_delta.value_);
   return LocalTimeDelta(Convert(remote_delta.value_));
 }
 
 int64_t InterProcessTimeTicksConverter::Convert(int64_t value) const {
   if (value <= 0) {
     return value;
   }
   return numerator_ * value / denominator_;
 }
 
 bool InterProcessTimeTicksConverter::IsSkewAdditiveForMetrics() const {
   return numerator_ == 1 && denominator_ == 1;
 }
 
 base::TimeDelta InterProcessTimeTicksConverter::GetSkewForMetrics() const {
   return base::TimeTicks::FromInternalValue(remote_lower_bound_) -
       base::TimeTicks::FromInternalValue(local_base_time_);
 }
 
 }  // namespace content