Issue 18282010: Cleanup: split FileSystemDispatcher::Create into CreateFile and CreateDirectory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18282010: Cleanup: split FileSystemDispatcher::Create into CreateFile and CreateDirectory (Closed)

Created:
7 years, 5 months ago by kinuko

Modified:
7 years, 5 months ago

Reviewers:
dmichael (off chromium), yzshen1, tzik

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch, jam, tzik+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Cleanup: split FileSystemDispatcher::Create into CreateFile and CreateDirectory Remotely for crbug.com/257349 BUG=none TEST=none R=dmichael@chromium.org, tzik@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211316

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -13 lines)			Patch
M	content/child/fileapi/file_system_dispatcher.h	View		1 chunk	+7 lines, -5 lines	0 comments	Download
M	content/child/fileapi/file_system_dispatcher.cc	View	1	1 chunk	+12 lines, -3 lines	0 comments	Download
M	content/child/fileapi/webfilesystem_impl.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	content/renderer/pepper/pepper_plugin_delegate_impl.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

kinuko

Very minor cleanup, remotely for other cleanups I'm working on

7 years, 5 months ago (2013-07-09 09:41:27 UTC) #1

kinuko

PTL tzik: content/child/fileapi yzshen: content/renderer/pepper

7 years, 5 months ago (2013-07-09 09:41:48 UTC) #2

kinuko

yzshen, dmichael: can either of you rubber stamp this small change in content/renderer/pepper? Thanks,

7 years, 5 months ago (2013-07-11 01:57:49 UTC) #4

dmichael (off chromium)

content/renderer/pepper lgtm, thanks. I always like reducing the number of cryptic bool params.

7 years, 5 months ago (2013-07-11 15:42:50 UTC) #5

kinuko

7 years, 5 months ago (2013-07-12 03:45:04 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r211316 (presubmit successful).