Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3656)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/android/tab_android.cc

Issue 1828193002: DCHECK that jstring to C++ string conversions don't pass in null. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: braces Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/data_usage/data_use_tab_ui_manager_android.cc ('k') | chrome/browser/prerender/external_prerender_handler_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/tab_android.cc
diff --git a/chrome/browser/android/tab_android.cc b/chrome/browser/android/tab_android.cc
index 1585e14dfcd9a5691616a7fe140f5d958ea42a41..34ae44bff52fdffd54ddd7ba87b77c7639838015 100644
--- a/chrome/browser/android/tab_android.cc
+++ b/chrome/browser/android/tab_android.cc
@@ -529,6 +529,9 @@ TabAndroid::TabLoadStatus TabAndroid::LoadUrl(
if (!web_contents())
return PAGE_LOAD_FAILED;
+ if (url.is_null())
+ return PAGE_LOAD_FAILED;
+
GURL gurl(base::android::ConvertJavaStringToUTF8(env, url));
if (gurl.is_empty())
return PAGE_LOAD_FAILED;
« no previous file with comments | « chrome/browser/android/data_usage/data_use_tab_ui_manager_android.cc ('k') | chrome/browser/prerender/external_prerender_handler_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698