chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java - Issue 1828193002: DCHECK that jstring to C++ string conversions don't pass in null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 1828193002: DCHECK that jstring to C++ string conversions don't pass in null. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: braces Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java ('k') | chrome/browser/android/data_usage/data_use_tab_ui_manager_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

index 17c95b141ccab82c0e09564979c63bf847ef0c9c..53b01b87606b848ea37db5724f2b8f60573dacfc 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

@@ -675,8 +675,9 @@ public final class Tab implements ViewGroup.OnHierarchyChangeListener,

mUrl = state.getVirtualUrlFromState();

mTitle = state.getDisplayTitleFromState();

- mIsTitleDirectionRtl = LocalizationUtils.getFirstStrongCharacterDirection(mTitle)

- == LocalizationUtils.RIGHT_TO_LEFT;

+ mIsTitleDirectionRtl = mTitle != null

+ && LocalizationUtils.getFirstStrongCharacterDirection(mTitle)

+ == LocalizationUtils.RIGHT_TO_LEFT;

}

/**