Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: build/common.gypi

Issue 1828143007: Web shell integration test suite. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Wrong GENERATOR plus some of Sylvain comments, but not all Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/ios.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index aea53b922e0f8e0491aa2dda13899dac58b39e66..7c4e60ede1586920c38b67cd49788b3c20f8dbde 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -5071,6 +5071,7 @@
# GCC_INLINES_ARE_PRIVATE_EXTERN maps to -fvisibility-inlines-hidden
'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES',
'GCC_OBJC_CALL_CXX_CDTORS': 'YES', # -fobjc-call-cxx-cdtors
+ 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
'GCC_THREADSAFE_STATICS': 'NO', # -fno-threadsafe-statics
'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror
'GCC_VERSION': 'com.apple.compilers.llvm.clang.1_0',
@@ -5159,29 +5160,6 @@
}],
],
}],
- ['OS=="mac"', {
- 'xcode_settings': {
- 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
- },
- }],
- ['OS=="ios"', {
- 'configurations': {
- 'Debug': {
- 'xcode_settings': {
- # XCTests inject a dynamic library into the application. If
- # fvisibility is set to hidden, then some symbols needed by
- # XCTests are not available. Disable this setting for
- # Debug configuration.
- 'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO',
- },
- },
- 'Release': {
- 'xcode_settings': {
- 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
- },
- },
- },
- }],
],
'target_conditions': [
['_type!="static_library"', {
« no previous file with comments | « no previous file | ios/ios.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698