Profile path is sent instead of an index to focus a user pod

ui/login/account_picker/user_pod_row.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview User pod row implementation.
  */
 
 cr.define('login', function() {
   /**
@@ skipping 2977 matching lines @@
           return pod;
       }
       return null;
     },
 
     /**
      * The pod that is preselected on user pod row show.
      * @type {?UserPod}
      */
     get preselectedPod() {
+      var i, pod;
       var isDesktopUserManager = Oobe.getInstance().displayType ==
           DISPLAY_TYPE.DESKTOP_USER_MANAGER;
       if (isDesktopUserManager) {
         // On desktop, don't pre-select a pod if it's the only one.
         if (this.pods.length == 1)
           return null;
 
-        // The desktop User Manager can send the index of a pod that should be
-        // initially focused in url hash.
-        var podIndex = parseInt(window.location.hash.substr(1));
-        if (isNaN(podIndex) || podIndex >= this.pods.length)
-          return null;
-        return this.pods[podIndex];
+        // The desktop User Manager can send an URI encoded profile path in the
+        // url hash, that indicates a pod that should be initially focused.
+        var focusedProfilePath =
+            decodeURIComponent(window.location.hash.substr(1));
+        for (i = 0; pod = this.pods[i]; ++i) {

[Dan Beam, 2016/03/30 17:53:29]

nit: i would just put

  for (var i = 0, pod; ...

here instead of at the top of the method

[lwchkg, 2016/03/31 14:48:16]

Done. However I do worry about non-JS coders thinking that putting var here
declares block scoped variables.

Anyway, WDYT about using "let" instead of "var"?

+          if (focusedProfilePath === pod.user.profilePath)
+            return pod;
+        }
+        return null;
       }
 
       var lockedPod = this.lockedPod;
       if (lockedPod)
         return lockedPod;
-      for (var i = 0, pod; pod = this.pods[i]; ++i) {
-        if (!pod.multiProfilesPolicyApplied) {
+      for (i = 0; pod = this.pods[i]; ++i) {
+        if (!pod.multiProfilesPolicyApplied)
           return pod;
-        }
       }
       return this.pods[0];
     },
 
     /**
      * Resets input UI.
      * @param {boolean} takeFocus True to take focus.
      */
     reset: function(takeFocus) {
       this.disabled = false;
@@ skipping 290 matching lines @@
        if (pod && pod.multiProfilesPolicyApplied) {
          pod.userTypeBubbleElement.classList.remove('bubble-shown');
        }
      }
   };
 
   return {
     PodRow: PodRow
   };
 });