Refine ash shelf tooltip closing on non-mash ChromeOS.

ash/shelf/shelf_tooltip_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/shelf/shelf_tooltip_manager.h"
 
 #include "ash/shelf/shelf_layout_manager.h"
 #include "ash/shelf/shelf_widget.h"
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
@@ skipping 155 matching lines @@
   generator.PressTouch();
   EXPECT_FALSE(TooltipIsVisible());
 
   // Should hide for gesture events in the shelf.
   ShowImmediately();
   ASSERT_TRUE(TooltipIsVisible());
   generator.GestureTapDownAndUp(shelf_bounds.CenterPoint());
   EXPECT_FALSE(TooltipIsVisible());
 }
 
-// TODO(msw): Hiding for touch and gesture events outside the shelf is broken.
-TEST_F(ShelfTooltipManagerTest, HideForEventsBroken) {
+TEST_F(ShelfTooltipManagerTest, HideForExternalEvents) {
+  ui::test::EventGenerator generator(ash::Shell::GetPrimaryRootWindow());
+  // TODO(msw): Observe events outside the shelf in mash, to close tooltips.
+  aura::Window* shelf_window = shelf_->shelf_widget()->GetNativeWindow();
+  bool closes = shelf_window->GetRootWindow() == Shell::GetPrimaryRootWindow();
+
+  // Should hide for touches outside the shelf.
+  ShowImmediately();
+  ASSERT_TRUE(TooltipIsVisible());
+  generator.set_current_location(gfx::Point());
+  generator.PressTouch();
+  EXPECT_EQ(TooltipIsVisible(), !closes);
+
+  // Should hide for touch events on the tooltip.
+  ShowImmediately();
+  ASSERT_TRUE(TooltipIsVisible());
+  generator.set_current_location(GetTooltipWindow()->bounds().CenterPoint());
+  generator.PressTouch();
+  EXPECT_EQ(TooltipIsVisible(), !closes);
+
+  // Should hide for gestures outside the shelf.
+  ShowImmediately();
+  ASSERT_TRUE(TooltipIsVisible());
+  generator.GestureTapDownAndUp(gfx::Point());
+  EXPECT_EQ(TooltipIsVisible(), !closes);
+}
+
+TEST_F(ShelfTooltipManagerTest, DoNotHideForKeyEvents) {
   ui::test::EventGenerator generator(ash::Shell::GetPrimaryRootWindow());
 
+  // Should not hide for key events.
   ShowImmediately();
   ASSERT_TRUE(TooltipIsVisible());
-
-  generator.set_current_location(gfx::Point());
-  generator.PressTouch();
-  EXPECT_TRUE(TooltipIsVisible());
-
-  generator.GestureTapDownAndUp(gfx::Point());
-  EXPECT_TRUE(TooltipIsVisible());
-}
-
-TEST_F(ShelfTooltipManagerTest, DoNotHideForEvents) {
-  ui::test::EventGenerator generator(ash::Shell::GetPrimaryRootWindow());
-
-  ShowImmediately();
-  ASSERT_TRUE(TooltipIsVisible());
-
-  // Should not hide for key events.
   generator.PressKey(ui::VKEY_A, ui::EF_NONE);
   EXPECT_TRUE(TooltipIsVisible());
-
-  // Should not hide for touch events on the tooltip.
-  generator.set_current_location(GetTooltipWindow()->bounds().CenterPoint());
-  generator.PressTouch();
-  EXPECT_TRUE(TooltipIsVisible());
 }
 
 }  // namespace test
 }  // namespace ash