tools/gn/ninja_build_writer.h - Issue 1828113002: 🌱 GN: Look at all target outputs when detecting duplicates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_build_writer.h

Issue 1828113002: 🌱 GN: Look at all target outputs when detecting duplicates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bye bye gmock Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/ninja_build_writer.h

diff --git a/tools/gn/ninja_build_writer.h b/tools/gn/ninja_build_writer.h

index 2df3365941d7584957ecf00fb48c7bf6739afa81..0d5b40eef70fe60d330cd91203e36cbcd4b172f0 100644

--- a/tools/gn/ninja_build_writer.h

+++ b/tools/gn/ninja_build_writer.h

@@ -30,7 +30,6 @@ class NinjaBuildWriter {

const std::vector<const Target*>& default_toolchain_targets,

Err* err);

- private:

NinjaBuildWriter(const BuildSettings* settings,

const std::vector<const Settings*>& all_settings,

const Toolchain* default_toolchain,

@@ -41,6 +40,7 @@ class NinjaBuildWriter {

bool Run(Err* err);

+ private:

void WriteNinjaRules();

void WriteLinkPool();

void WriteSubninjas();

« no previous file with comments | « tools/gn/BUILD.gn ('k') | tools/gn/ninja_build_writer.cc » ('j') | no next file with comments »