Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: tools/gn/BUILD.gn

Issue 1828113002: 🌱 GN: Look at all target outputs when detecting duplicates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/ninja_build_writer.h » ('j') | tools/gn/ninja_build_writer_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/BUILD.gn
diff --git a/tools/gn/BUILD.gn b/tools/gn/BUILD.gn
index 37bce8d89035705820edc6e528ee26cc723b256b..cbc16afef2b483e4ab9342cf066883518e0ff2eb 100644
--- a/tools/gn/BUILD.gn
+++ b/tools/gn/BUILD.gn
@@ -285,6 +285,7 @@ test("gn_unittests") {
"loader_unittest.cc",
"ninja_action_target_writer_unittest.cc",
"ninja_binary_target_writer_unittest.cc",
+ "ninja_build_writer_unittest.cc",
"ninja_copy_target_writer_unittest.cc",
"ninja_create_bundle_target_writer_unittest.cc",
"ninja_group_target_writer_unittest.cc",
@@ -324,6 +325,7 @@ test("gn_unittests") {
":gn_lib",
"//base/test:run_all_unittests",
"//base/test:test_support",
+ "//testing/gmock",
"//testing/gtest",
]
}
« no previous file with comments | « no previous file | tools/gn/ninja_build_writer.h » ('j') | tools/gn/ninja_build_writer_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698