Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: net/base/sdch_manager.cc

Issue 1828103002: Extend net/base/parse_number.h for parsing of negative numbers, and determining if there was overflo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@proxy_num
Patch Set: improve comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/sdch_manager.cc
diff --git a/net/base/sdch_manager.cc b/net/base/sdch_manager.cc
index 435977237d83d4856008b9c442bf3946f3c36091..78f7a01d17e61a361ea59147f8b2b238ed9e50be 100644
--- a/net/base/sdch_manager.cc
+++ b/net/base/sdch_manager.cc
@@ -382,7 +382,7 @@ SdchProblemCode SdchManager::AddSdchDictionary(
expiration = base::Time::Now() + base::TimeDelta::FromSeconds(seconds);
} else if (name == "port") {
int port;
- if (ParseNonNegativeDecimalInt(value, &port))
+ if (ParseIntegerBase10(value, false, &port, nullptr))
ports.insert(port);
}
}

Powered by Google App Engine
This is Rietveld 408576698