net/base/ip_address.cc - Issue 1828103002: Extend net/base/parse_number.h for parsing of negative numbers, and determining if there was overflo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/ip_address.cc

Issue 1828103002: Extend net/base/parse_number.h for parsing of negative numbers, and determining if there was overflo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@proxy_num

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/ip_address.cc

diff --git a/net/base/ip_address.cc b/net/base/ip_address.cc

index b805317eef3675ea0dafe63353bef32bb199c8aa..3dc9ea471424873a88d607b6c81dcd1c2fd41a07 100644

--- a/net/base/ip_address.cc

+++ b/net/base/ip_address.cc

@@ -181,7 +181,7 @@ bool ParseCIDRBlock(const std::string& cidr_literal,

// Parse the prefix length.

int number_of_bits = -1;

- if (!ParseNonNegativeDecimalInt(parts[1], &number_of_bits))

+ if (!ParseNonNegativeInteger(parts[1], &number_of_bits))

return false;

// Make sure the prefix length is in a valid range.

« no previous file with comments | « net/base/host_port_pair.cc ('k') | net/base/parse_number.h » ('j') | net/base/parse_number_unittest.cc » ('J')