third_party/WebKit/Source/bindings/templates/utilities.cpp - Issue 1828063002: Add support for origin trials in workers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/utilities.cpp

Issue 1828063002: Add support for origin trials in workers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@trial-token-in-header-blink-document

Patch Set: fix test flakyness Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/test-helpers.js ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/utilities.cpp

diff --git a/third_party/WebKit/Source/bindings/templates/utilities.cpp b/third_party/WebKit/Source/bindings/templates/utilities.cpp

index 4695997d86397cd8b09e8585bf6824f0a7dc4513..1ba1dfe8d83da5deb4ed2df85156fcdda905435c 100644

--- a/third_party/WebKit/Source/bindings/templates/utilities.cpp

+++ b/third_party/WebKit/Source/bindings/templates/utilities.cpp

@@ -61,7 +61,7 @@ String errorMessage;

if (!{{member.origin_trial_enabled_function}}(executionContext, errorMessage)) {

v8SetReturnValue(info, v8::Undefined(info.GetIsolate()));

if (!errorMessage.isEmpty()) {

- toDocument(executionContext)->addConsoleMessage(ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, errorMessage));

+ executionContext->addConsoleMessage(ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, errorMessage));

}

return;

}