Add support for origin trials in workers.

third_party/WebKit/Source/core/workers/WorkerThreadStartupData.h

Index: third_party/WebKit/Source/core/workers/WorkerThreadStartupData.h
diff --git a/third_party/WebKit/Source/core/workers/WorkerThreadStartupData.h b/third_party/WebKit/Source/core/workers/WorkerThreadStartupData.h
index cc3501f0e10035d5b890781438110281ef6bc666..6767b815f697bf996fd732f042a5c773b1d3af2b 100644
--- a/third_party/WebKit/Source/core/workers/WorkerThreadStartupData.h
+++ b/third_party/WebKit/Source/core/workers/WorkerThreadStartupData.h
@@ -50,9 +50,9 @@ class CORE_EXPORT WorkerThreadStartupData final {
     WTF_MAKE_NONCOPYABLE(WorkerThreadStartupData);
     USING_FAST_MALLOC(WorkerThreadStartupData);
 public:
-    static PassOwnPtr<WorkerThreadStartupData> create(const KURL& scriptURL, const String& userAgent, const String& sourceCode, PassOwnPtr<Vector<char>> cachedMetaData, WorkerThreadStartMode startMode, PassOwnPtr<Vector<CSPHeaderAndType>> contentSecurityPolicyHeaders, const SecurityOrigin* starterOrigin, WorkerClients* workerClients, WebAddressSpace addressSpace, V8CacheOptions v8CacheOptions = V8CacheOptionsDefault)
+    static PassOwnPtr<WorkerThreadStartupData> create(const KURL& scriptURL, const String& userAgent, const String& sourceCode, PassOwnPtr<Vector<char>> cachedMetaData, WorkerThreadStartMode startMode, const Vector<CSPHeaderAndType>* contentSecurityPolicyHeaders, const SecurityOrigin* starterOrigin, WorkerClients* workerClients, WebAddressSpace addressSpace, const Vector<String>* originTrialTokens, V8CacheOptions v8CacheOptions = V8CacheOptionsDefault)

[iclelland, 2016/04/28 15:39:22]

Why isn't the ownership of originTrialTokens (and contentSecurityPolicyHeaders)
transferred when creating the WorkerThreadStartupData?

It looks like it used to be, for CSP, but isn't now -- it's just a raw pointer
whose contents get explicitly copied, and it's up to the caller to dispose of
the original, and originTrialTokens is the same. Was there a reason for not
keeping the PassOwnPtr, and using std::unique_ptr<Vector<String>> as the
argument type for originTrialTokens here?

[Marijn Kruisselbrink, 2016/04/28 17:45:27]

It actually never transferred ownership for CSP. Until the recent cleanup to not
copy PassOwnPtr instances around this in fact took a "const PassOwnPtr<>" rather
than just a PassOwnPtr, which already made it impossible to actually transfer
ownership. WorkerThreadStartupData has to make copies of anything containing
strings since strings aren't thread-safe in blink. So WorkerThreadStartupData
didn't and doesn't gain ownership of anything containing strings that was passed
on. So since it isn't actually getting ownership of some existing structure it
seemed kind of pointless (and weird) to require the caller to give up ownership.
Using raw pointers more accurately reflects the semantics.

[iclelland, 2016/04/28 18:02:52]

Got it -- I missed the const ref, but that makes sense now. Thanks.

     {
-        return adoptPtr(new WorkerThreadStartupData(scriptURL, userAgent, sourceCode, std::move(cachedMetaData), startMode, std::move(contentSecurityPolicyHeaders), starterOrigin, workerClients, addressSpace, v8CacheOptions));
+        return adoptPtr(new WorkerThreadStartupData(scriptURL, userAgent, sourceCode, cachedMetaData, startMode, contentSecurityPolicyHeaders, starterOrigin, workerClients, addressSpace, originTrialTokens, v8CacheOptions));
     }
 
     ~WorkerThreadStartupData();
@@ -63,6 +63,7 @@ public:
     OwnPtr<Vector<char>> m_cachedMetaData;
     WorkerThreadStartMode m_startMode;
     OwnPtr<Vector<CSPHeaderAndType>> m_contentSecurityPolicyHeaders;
+    std::unique_ptr<Vector<String>> m_originTrialTokens;
 
 
     // The SecurityOrigin of the Document creating a Worker may have
@@ -91,7 +92,7 @@ public:
     V8CacheOptions m_v8CacheOptions;
 
 private:
-    WorkerThreadStartupData(const KURL& scriptURL, const String& userAgent, const String& sourceCode, PassOwnPtr<Vector<char>> cachedMetaData, WorkerThreadStartMode, PassOwnPtr<Vector<CSPHeaderAndType>> contentSecurityPolicyHeaders, const SecurityOrigin*, WorkerClients*, WebAddressSpace, V8CacheOptions);
+    WorkerThreadStartupData(const KURL& scriptURL, const String& userAgent, const String& sourceCode, PassOwnPtr<Vector<char>> cachedMetaData, WorkerThreadStartMode, const Vector<CSPHeaderAndType>* contentSecurityPolicyHeaders, const SecurityOrigin*, WorkerClients*, WebAddressSpace, const Vector<String>* originTrialTokens, V8CacheOptions);
 };
 
 } // namespace blink