Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 1827993002: [DevTools] Remove promise inspector experiment (Closed)

Created:
4 years, 9 months ago by kozy
Modified:
4 years, 9 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kinuko+watch, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove promise inspector experiment We decided to remove this experiment because it doesn't really help in most scenarios. We should instead polish async stacks and finish async stepping to make debugging of promises and any other async code easy. BUG=526811, 348919, 587850 R=dgozman@chromium.org,pfeldman@chromium.org Committed: https://crrev.com/559a35b9574ea1e17b2d6ccc5bc4f0cc955bb570 Cr-Commit-Position: refs/heads/master@{#383328}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1828 lines) Patch
D third_party/WebKit/LayoutTests/inspector/sources/debugger/promise-events.html View 1 chunk +0 lines, -112 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/sources/debugger/promise-events-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/sources/debugger/promise-pane.html View 1 chunk +0 lines, -120 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/sources/debugger/promise-pane-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/sources/debugger/promise-tracker.html View 1 chunk +0 lines, -115 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector/sources/debugger/promise-tracker-expected.txt View 1 chunk +0 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/devtools.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/devtools.gypi View 1 2 3 3 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/inspector.json View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/promises/PromisePane.js View 1 chunk +0 lines, -791 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/promises/module.json View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/promises/promisePane.css View 1 chunk +0 lines, -95 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js View 4 chunks +1 line, -58 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 1 2 3 3 chunks +0 lines, -49 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js View 1 2 3 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/Source/platform/v8_inspector/PromiseTracker.h View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/Source/platform/v8_inspector/PromiseTracker.cpp View 1 chunk +0 lines, -160 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h View 1 2 3 4 chunks +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 1 2 3 10 chunks +0 lines, -64 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp View 1 2 3 3 chunks +1 line, -21 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
kozy
Please take a look!
4 years, 9 months ago (2016-03-23 21:26:18 UTC) #3
dgozman
lgtm
4 years, 9 months ago (2016-03-23 21:35:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827993002/40001
4 years, 9 months ago (2016-03-23 21:37:36 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/160231)
4 years, 9 months ago (2016-03-23 21:49:39 UTC) #11
kozy
Pavel, please take a look. I need owner lgtm for third_party/WebKit/Source/platform/blink_platform.gypi.
4 years, 9 months ago (2016-03-23 21:53:37 UTC) #12
pfeldman
lgtm
4 years, 9 months ago (2016-03-25 17:53:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827993002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827993002/60001
4 years, 9 months ago (2016-03-25 18:09:37 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-25 19:20:47 UTC) #18
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 19:22:17 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/559a35b9574ea1e17b2d6ccc5bc4f0cc955bb570
Cr-Commit-Position: refs/heads/master@{#383328}

Powered by Google App Engine
This is Rietveld 408576698