Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1827963002: Draw black on white for CG glyph masks. (Closed)

Created:
4 years, 9 months ago by bungeman-skia
Modified:
4 years, 9 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Stage behind flag. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -14 lines) Patch
M src/ports/SkFontHost_mac.cpp View 1 12 chunks +33 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827963002/20001
4 years, 9 months ago (2016-03-24 04:23:44 UTC) #3
bungeman-skia
The suppression flag is going into Chromium at https://codereview.chromium.org/1832753002/ (the layout tests on Mac currently ...
4 years, 9 months ago (2016-03-24 04:35:20 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-24 04:38:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827963002/20001
4 years, 9 months ago (2016-03-24 13:27:55 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 9 months ago (2016-03-24 13:27:56 UTC) #10
mtklein
lgtm
4 years, 9 months ago (2016-03-24 18:25:14 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 18:27:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e280d06f3e5fcf12bc34ebabd9bca7965af45112

Powered by Google App Engine
This is Rietveld 408576698