Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1827923002: Move xfa/include/fwl/{core,basewidget} to xfa/fwl/{core,basewidget}. (Closed)

Created:
4 years, 9 months ago by dsinclair
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move xfa/include/fwl/{core,basewidget} to xfa/fwl/{core,basewidget}. This CL moves and splits the FWL files from the core and basewidget directories into the non-include folders. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/398a43d83174d75366da57726ff81f199f04e24c

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1454 lines, -4281 lines) Patch
M BUILD.gn View 1 2 3 chunks +49 lines, -34 lines 0 comments Download
A fpdfsdk/include/fpdfxfa/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M fpdfsdk/include/fpdfxfa/fpdfxfa_util.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa.gyp View 3 chunks +49 lines, -34 lines 0 comments Download
D xfa/fde/css/#fde_cssstyleselector.h# View 1 2 1 chunk +0 lines, -901 lines 0 comments Download
M xfa/fwl/basewidget/fwl_barcodeimp.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fwl/basewidget/fwl_barcodeimp.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_caretimp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_caretimp.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/fwl_checkboximp.h View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_checkboximp.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/fwl_comboboximp.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_datetimepickerimp.h View 1 chunk +4 lines, -5 lines 0 comments Download
M xfa/fwl/basewidget/fwl_datetimepickerimp.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_editimp.h View 1 chunk +5 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_editimp.cpp View 1 chunk +6 lines, -3 lines 0 comments Download
M xfa/fwl/basewidget/fwl_listboximp.h View 1 chunk +7 lines, -4 lines 0 comments Download
M xfa/fwl/basewidget/fwl_listboximp.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_monthcalendarimp.h View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_monthcalendarimp.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/fwl_pushbuttonimp.h View 2 chunks +3 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_pushbuttonimp.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_scrollbarimp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_scrollbarimp.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/fwl_spinbuttonimp.h View 1 chunk +4 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/fwl_spinbuttonimp.cpp View 1 chunk +7 lines, -3 lines 0 comments Download
M xfa/fwl/basewidget/fwl_tooltipctrlimp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_tooltipctrlimp.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/fxmath_barcodeimp.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + xfa/fwl/basewidget/ifwl_barcode.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/fwl/basewidget/ifwl_caret.h View 2 chunks +5 lines, -4 lines 0 comments Download
A + xfa/fwl/basewidget/ifwl_checkbox.h View 3 chunks +8 lines, -5 lines 0 comments Download
A + xfa/fwl/basewidget/ifwl_combobox.h View 4 chunks +20 lines, -9 lines 0 comments Download
A + xfa/fwl/basewidget/ifwl_datetimepicker.h View 3 chunks +8 lines, -5 lines 0 comments Download
A + xfa/fwl/basewidget/ifwl_edit.h View 5 chunks +24 lines, -17 lines 0 comments Download
A + xfa/fwl/basewidget/ifwl_listbox.h View 5 chunks +19 lines, -13 lines 0 comments Download
A + xfa/fwl/basewidget/ifwl_monthcalendar.h View 2 chunks +7 lines, -5 lines 0 comments Download
A + xfa/fwl/basewidget/ifwl_picturebox.h View 3 chunks +9 lines, -3 lines 0 comments Download
A + xfa/fwl/basewidget/ifwl_pushbutton.h View 3 chunks +9 lines, -4 lines 0 comments Download
A + xfa/fwl/basewidget/ifwl_scrollbar.h View 1 2 2 chunks +8 lines, -3 lines 0 comments Download
A + xfa/fwl/basewidget/ifwl_spinbutton.h View 3 chunks +4 lines, -3 lines 0 comments Download
A + xfa/fwl/basewidget/ifwl_tooltip.h View 3 chunks +5 lines, -4 lines 0 comments Download
A + xfa/fwl/basewidget/ifx_barcode.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A xfa/fwl/core/cfwl_event.h View 1 2 1 chunk +145 lines, -0 lines 0 comments Download
A xfa/fwl/core/cfwl_message.h View 1 2 1 chunk +159 lines, -0 lines 0 comments Download
A xfa/fwl/core/cfwl_note.h View 1 2 1 chunk +67 lines, -0 lines 0 comments Download
A xfa/fwl/core/cfwl_themebackground.h View 1 chunk +25 lines, -0 lines 0 comments Download
A xfa/fwl/core/cfwl_themepart.h View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
A xfa/fwl/core/cfwl_themetext.h View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
A xfa/fwl/core/cfwl_widgetimpproperties.h View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
M xfa/fwl/core/fwl_appimp.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fwl/core/fwl_contentimp.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + xfa/fwl/core/fwl_error.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fwl/core/fwl_formimp.h View 1 chunk +4 lines, -2 lines 0 comments Download
M xfa/fwl/core/fwl_formimp.cpp View 2 chunks +8 lines, -4 lines 0 comments Download
M xfa/fwl/core/fwl_gridimp.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fwl/core/fwl_gridimp.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/fwl/core/fwl_noteimp.h View 5 chunks +22 lines, -8 lines 0 comments Download
M xfa/fwl/core/fwl_noteimp.cpp View 1 2 5 chunks +16 lines, -14 lines 0 comments Download
M xfa/fwl/core/fwl_panelimp.cpp View 1 chunk +6 lines, -3 lines 0 comments Download
A + xfa/fwl/core/fwl_sdadapterimp.h View 2 chunks +5 lines, -5 lines 0 comments Download
M xfa/fwl/core/fwl_sdadapterimp.cpp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fwl/core/fwl_targetimp.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/fwl_threadimp.h View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fwl/core/fwl_threadimp.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fwl/core/fwl_timerimp.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + xfa/fwl/core/fwl_widgetdef.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fwl/core/fwl_widgetimp.h View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M xfa/fwl/core/fwl_widgetimp.cpp View 1 chunk +18 lines, -10 lines 0 comments Download
M xfa/fwl/core/fwl_widgetmgrimp.h View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/fwl/core/fwl_widgetmgrimp.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
A + xfa/fwl/core/ifwl_adapternative.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + xfa/fwl/core/ifwl_adapterthreadmgr.h View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
A + xfa/fwl/core/ifwl_adapterwidgetmgr.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/fwl/core/ifwl_app.h View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
A + xfa/fwl/core/ifwl_content.h View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
A xfa/fwl/core/ifwl_custom.h View 1 chunk +26 lines, -0 lines 0 comments Download
A + xfa/fwl/core/ifwl_custompanel.h View 2 chunks +6 lines, -20 lines 0 comments Download
A xfa/fwl/core/ifwl_dataprovider.h View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A + xfa/fwl/core/ifwl_form.h View 1 2 5 chunks +21 lines, -11 lines 0 comments Download
A + xfa/fwl/core/ifwl_grid.h View 4 chunks +8 lines, -4 lines 0 comments Download
A xfa/fwl/core/ifwl_notedriver.h View 1 2 1 chunk +58 lines, -0 lines 0 comments Download
A xfa/fwl/core/ifwl_noteloop.h View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A xfa/fwl/core/ifwl_notethread.h View 1 chunk +19 lines, -0 lines 0 comments Download
A + xfa/fwl/core/ifwl_panel.h View 2 chunks +4 lines, -16 lines 0 comments Download
A xfa/fwl/core/ifwl_proxy.h View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A + xfa/fwl/core/ifwl_target.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/fwl/core/ifwl_themeprovider.h View 1 2 3 chunks +9 lines, -39 lines 0 comments Download
A + xfa/fwl/core/ifwl_thread.h View 3 chunks +4 lines, -9 lines 0 comments Download
A + xfa/fwl/core/ifwl_timer.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A xfa/fwl/core/ifwl_tooltiptarget.h View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
A + xfa/fwl/core/ifwl_widget.h View 1 2 2 chunks +13 lines, -64 lines 0 comments Download
A xfa/fwl/core/ifwl_widgetdelegate.h View 1 chunk +26 lines, -0 lines 0 comments Download
A + xfa/fwl/core/ifwl_widgetmgr.h View 1 2 2 chunks +9 lines, -18 lines 0 comments Download
A xfa/fwl/core/ifwl_widgetmgrdelegate.h View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
A + xfa/fwl/core/include/ifwl_adaptertimermgr.h View 2 chunks +5 lines, -5 lines 0 comments Download
M xfa/fwl/lightwidget/app.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/lightwidget/caret.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/lightwidget/checkbox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/lightwidget/combobox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/lightwidget/datetimepicker.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M xfa/fwl/lightwidget/edit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/lightwidget/scrollbar.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/lightwidget/theme.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/fwl/lightwidget/widget.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/fwl/theme/barcodetp.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fwl/theme/carettp.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/fwl/theme/checkboxtp.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M xfa/fwl/theme/comboboxtp.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M xfa/fwl/theme/datetimepickertp.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fwl/theme/edittp.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/fwl/theme/formtp.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M xfa/fwl/theme/listboxtp.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/fwl/theme/monthcalendartp.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M xfa/fwl/theme/pictureboxtp.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M xfa/fwl/theme/pushbuttontp.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M xfa/fwl/theme/scrollbartp.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M xfa/fwl/theme/widgettp.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffapp.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_ffapp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffbarcode.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffcheckbutton.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffchoicelist.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdoc.cpp View 1 2 2 chunks +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fffield.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_fffield.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffimageedit.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffpushbutton.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fftext.cpp View 2 chunks +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fftextedit.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_fwladapter.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fwltheme.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_fwltheme.cpp View 1 chunk +13 lines, -11 lines 0 comments Download
D xfa/include/fwl/adapter/fwl_adapternative.h View 1 chunk +0 lines, -24 lines 0 comments Download
D xfa/include/fwl/adapter/fwl_adapterthreadmgr.h View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
D xfa/include/fwl/adapter/fwl_adaptertimermgr.h View 1 chunk +0 lines, -25 lines 0 comments Download
D xfa/include/fwl/adapter/fwl_adapterwidgetmgr.h View 1 2 1 chunk +0 lines, -81 lines 0 comments Download
D xfa/include/fwl/adapter/fwl_sdadapterimp.h View 1 chunk +0 lines, -89 lines 0 comments Download
D xfa/include/fwl/basewidget/fwl_barcode.h View 1 chunk +0 lines, -63 lines 0 comments Download
D xfa/include/fwl/basewidget/fwl_caret.h View 1 chunk +0 lines, -32 lines 0 comments Download
D xfa/include/fwl/basewidget/fwl_checkbox.h View 1 chunk +0 lines, -82 lines 0 comments Download
D xfa/include/fwl/basewidget/fwl_combobox.h View 1 chunk +0 lines, -141 lines 0 comments Download
D xfa/include/fwl/basewidget/fwl_datetimepicker.h View 1 chunk +0 lines, -112 lines 0 comments Download
D xfa/include/fwl/basewidget/fwl_edit.h View 1 chunk +0 lines, -171 lines 0 comments Download
D xfa/include/fwl/basewidget/fwl_listbox.h View 1 chunk +0 lines, -136 lines 0 comments Download
D xfa/include/fwl/basewidget/fwl_menu.h View 1 chunk +0 lines, -17 lines 0 comments Download
D xfa/include/fwl/basewidget/fwl_monthcalendar.h View 1 chunk +0 lines, -137 lines 0 comments Download
D xfa/include/fwl/basewidget/fwl_picturebox.h View 1 chunk +0 lines, -53 lines 0 comments Download
D xfa/include/fwl/basewidget/fwl_pushbutton.h View 1 chunk +0 lines, -56 lines 0 comments Download
D xfa/include/fwl/basewidget/fwl_scrollbar.h View 1 chunk +0 lines, -72 lines 0 comments Download
D xfa/include/fwl/basewidget/fwl_spinbutton.h View 1 chunk +0 lines, -43 lines 0 comments Download
D xfa/include/fwl/basewidget/fwl_tooltipctrl.h View 1 chunk +0 lines, -48 lines 0 comments Download
D xfa/include/fwl/basewidget/fxmath_barcode.h View 1 2 1 chunk +0 lines, -62 lines 0 comments Download
D xfa/include/fwl/core/fwl_app.h View 1 2 1 chunk +0 lines, -44 lines 0 comments Download
D xfa/include/fwl/core/fwl_content.h View 1 chunk +0 lines, -27 lines 0 comments Download
D xfa/include/fwl/core/fwl_error.h View 1 chunk +0 lines, -22 lines 0 comments Download
D xfa/include/fwl/core/fwl_form.h View 1 chunk +0 lines, -87 lines 0 comments Download
D xfa/include/fwl/core/fwl_grid.h View 1 chunk +0 lines, -89 lines 0 comments Download
D xfa/include/fwl/core/fwl_note.h View 1 2 1 chunk +0 lines, -381 lines 0 comments Download
D xfa/include/fwl/core/fwl_panel.h View 1 chunk +0 lines, -42 lines 0 comments Download
D xfa/include/fwl/core/fwl_target.h View 1 2 1 chunk +0 lines, -52 lines 0 comments Download
D xfa/include/fwl/core/fwl_theme.h View 1 2 1 chunk +0 lines, -88 lines 0 comments Download
D xfa/include/fwl/core/fwl_thread.h View 1 chunk +0 lines, -53 lines 0 comments Download
D xfa/include/fwl/core/fwl_timer.h View 1 2 1 chunk +0 lines, -24 lines 0 comments Download
D xfa/include/fwl/core/fwl_widget.h View 1 chunk +0 lines, -120 lines 0 comments Download
D xfa/include/fwl/core/fwl_widgetdef.h View 1 chunk +0 lines, -249 lines 0 comments Download
D xfa/include/fwl/core/fwl_widgetmgr.h View 1 chunk +0 lines, -60 lines 0 comments Download
M xfa/include/fwl/lightwidget/app.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/lightwidget/barcode.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/include/fwl/lightwidget/caret.h View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/include/fwl/lightwidget/checkbox.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/lightwidget/combobox.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/lightwidget/datetimepicker.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/lightwidget/listbox.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/include/fwl/lightwidget/picturebox.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/include/fwl/lightwidget/pushbutton.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/lightwidget/theme.h View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M xfa/include/fwl/lightwidget/tooltipctrl.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/lightwidget/widget.h View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/include/fwl/theme/widgettp.h View 1 2 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dsinclair
PTAL.
4 years, 9 months ago (2016-03-23 18:39:41 UTC) #2
Tom Sepez
lgtm
4 years, 9 months ago (2016-03-23 19:47:16 UTC) #3
dsinclair
4 years, 9 months ago (2016-03-23 19:51:05 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
398a43d83174d75366da57726ff81f199f04e24c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698