Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 18279002: Separate showing and hiding the debugger settings and inspector. (Closed)

Created:
7 years, 5 months ago by bungeman-skia
Modified:
7 years, 5 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Separate showing and hiding the debugger settings and inspector. Internally the settings and inspector in the debugger are separate, but the inspector button toggles both of them. This is unfortunate, because both of these have large minimum vertical sizes. This means that those with vertical resolutions less than ~1024 cannot see the the details tab. This change separates the settings and inspector toggles into two so that the interface is usable on screens of smaller size. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=9835

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M debugger/QT/SkDebuggerGUI.h View 1 chunk +1 line, -0 lines 0 comments Download
M debugger/QT/SkDebuggerGUI.cpp View 5 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
bungeman-skia
I was on my laptop with only 900px vertically, and I couldn't even see the ...
7 years, 5 months ago (2013-06-29 21:28:02 UTC) #1
robertphillips
lgtm
7 years, 5 months ago (2013-06-30 17:22:06 UTC) #2
bungeman-skia
7 years, 5 months ago (2013-07-01 14:24:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r9835 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698