Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: chrome/browser/net/ftp_browsertest.cc

Issue 1827893002: Fix handling of escaped slashes ("%2f") in FTP paths. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/files/file_path.h" 6 #include "base/files/file_path.h"
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 #include "chrome/browser/ui/browser.h" 9 #include "chrome/browser/ui/browser.h"
10 #include "chrome/browser/ui/tabs/tab_strip_model.h" 10 #include "chrome/browser/ui/tabs/tab_strip_model.h"
(...skipping 26 matching lines...) Expand all
37 } 37 }
38 38
39 IN_PROC_BROWSER_TEST_F(FtpBrowserTest, BasicFtpUrlAuthentication) { 39 IN_PROC_BROWSER_TEST_F(FtpBrowserTest, BasicFtpUrlAuthentication) {
40 ASSERT_TRUE(ftp_server_.Start()); 40 ASSERT_TRUE(ftp_server_.Start());
41 ui_test_utils::NavigateToURL( 41 ui_test_utils::NavigateToURL(
42 browser(), 42 browser(),
43 ftp_server_.GetURLWithUserAndPassword("", "chrome", "chrome")); 43 ftp_server_.GetURLWithUserAndPassword("", "chrome", "chrome"));
44 44
45 WaitForTitle(browser()->tab_strip_model()->GetActiveWebContents(), 45 WaitForTitle(browser()->tab_strip_model()->GetActiveWebContents(),
46 "Index of /"); 46 "Index of /");
47 base::RunLoop().Run();
47 } 48 }
48 49
49 // http://crbug.com/521409 50 // http://crbug.com/521409
50 #if defined(OS_WIN) 51 #if defined(OS_WIN)
51 #define MAYBE_DirectoryListingNavigation DISABLED_DirectoryListingNavigation 52 #define MAYBE_DirectoryListingNavigation DISABLED_DirectoryListingNavigation
52 #else 53 #else
53 #define MAYBE_DirectoryListingNavigation DirectoryListingNavigation 54 #define MAYBE_DirectoryListingNavigation DirectoryListingNavigation
54 #endif 55 #endif
55 IN_PROC_BROWSER_TEST_F(FtpBrowserTest, MAYBE_DirectoryListingNavigation) { 56 IN_PROC_BROWSER_TEST_F(FtpBrowserTest, MAYBE_DirectoryListingNavigation) {
56 ftp_server_.set_no_anonymous_ftp_user(true); 57 ftp_server_.set_no_anonymous_ftp_user(true);
(...skipping 21 matching lines...) Expand all
78 "var elements = document.getElementsByTagName('a');" 79 "var elements = document.getElementsByTagName('a');"
79 "for (var i = 0; i < elements.length; i++) {" 80 "for (var i = 0; i < elements.length; i++) {"
80 " if (elements[i].innerHTML == 'test.html') {" 81 " if (elements[i].innerHTML == 'test.html') {"
81 " elements[i].click();" 82 " elements[i].click();"
82 " }" 83 " }"
83 "}")); 84 "}"));
84 85
85 WaitForTitle(browser()->tab_strip_model()->GetActiveWebContents(), 86 WaitForTitle(browser()->tab_strip_model()->GetActiveWebContents(),
86 "PASS"); 87 "PASS");
87 } 88 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698