Fix handling of escaped slashes ("%2f") in FTP paths.

Fix handling of escaped slashes ("%2f") in FTP paths.

Chrome was unescaping them before sending requests to the server, which
would map "ftp://foo/bar%2f..%2fblah" to requesting path "/bar/../blah"
from the FTP server, which is weird.  It now requests the file named
"bar%2f..%2fblah" instead.  Worth noting that GURL considers this to be
a separate url from ftp://foo/blah, so its best to be consistent with
that behavior.  Also, when Chrome sees an FTP file with %'s in its name,
it unescapes them, so Chrome would never generate a URL with "%2f" in
it, but they could still come from external sources.

This CL also fixes the title of directory listings of paths with "%2f"
in them - ftp://foo/bar%2f/baz will now say "Index of /bar%2f/" instead
of "Index of /bar//".

BUG=597056
Committed: https://crrev.com/0a2a0e15f6741225fbce75cfc4fa07db0a00190d
Cr-Commit-Position: refs/heads/master@{#382961}

[mmenke, 2016-03-23 16:49:00]

mmenke@chromium.org changed reviewers:
+ eroman@chromium.org

[mmenke, 2016-03-23 16:49:00]

I've tested this manually, and everything seems to be working fine.  Could add
more tests, but I'm not sure it's worth it.

https://codereview.chromium.org/1827893002/diff/1/content/child/ftp_directory...
File content/child/ftp_directory_listing_response_delegate.cc (right):

https://codereview.chromium.org/1827893002/diff/1/content/child/ftp_directory...
content/child/ftp_directory_listing_response_delegate.cc:116:
net::UnescapeRule::URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS;
Note that this only affects display of the "Index of /blah/" line.  I could
write a test for this, but I only see browser tests for this file.  Easy enough
to write one of those that tests this, but seems like overkill.

[eroman, 2016-03-23 16:59:07]

In the CL description:

"separature url" --> "separate URL"

> GURL considers this to be a separature url from ftp://foo/blah,

Otherwise LGTM




> ftp://foo/bar%2f..%2fblah

[mmenke, 2016-03-23 17:00:35]

Description was changed from

==========
Fix handling of escaped slashes ("%2f") in FTP paths.

Chrome was unescaping them before sending requests to the server, which
would map "ftp://foo/bar%2f..%2fblah" to requesting path "/bar/../blah"
from the FTP server, which is weird.  It now requests the file named
"bar%2f..%2fblah" instead.  Worth noting that GURL considers this to be
a separature url from ftp://foo/blah, so its best to be consistent with
that behavior.  Also, when Chrome sees an FTP file with %'s in its name,
it unescapes them, so Chrome would never generate a URL with "%2f" in
it, but they could still come from external sources.

This CL also fixes the title of directory listings of paths with "%2f"
in them - ftp://foo/bar%2f/baz will now say "Index of /bar%2f/" instead
of "Index of /bar//".

BUG=597056
==========

to

==========
Fix handling of escaped slashes ("%2f") in FTP paths.

Chrome was unescaping them before sending requests to the server, which
would map "ftp://foo/bar%2f..%2fblah" to requesting path "/bar/../blah"
from the FTP server, which is weird.  It now requests the file named
"bar%2f..%2fblah" instead.  Worth noting that GURL considers this to be
a separate url from ftp://foo/blah, so its best to be consistent with
that behavior.  Also, when Chrome sees an FTP file with %'s in its name,
it unescapes them, so Chrome would never generate a URL with "%2f" in
it, but they could still come from external sources.

This CL also fixes the title of directory listings of paths with "%2f"
in them - ftp://foo/bar%2f/baz will now say "Index of /bar%2f/" instead
of "Index of /bar//".

BUG=597056
==========

[mmenke, 2016-03-23 17:05:41]

mmenke@chromium.org changed reviewers:
+ jam@chromium.org

[mmenke, 2016-03-23 17:05:41]

[+jam]:  Need an OWNER signoff for
	content/child/ftp_directory_listing_response_delegate.cc.  Note that change
only affects the "Index of /blah/" display at the top of FTP directory listings.

Thanks!

[jam, 2016-03-23 20:00:51]

lgtm

[mmenke, 2016-03-23 20:12:45]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2016-03-23 20:12:45]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org,
jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1827893002/#ps20001
(title: "Remove accidentally included test code")

[commit-bot: I haz the power, 2016-03-23 20:13:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1827893002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1827893002/20001

[commit-bot: I haz the power, 2016-03-23 23:06:57]

Description was changed from

==========
Fix handling of escaped slashes ("%2f") in FTP paths.

Chrome was unescaping them before sending requests to the server, which
would map "ftp://foo/bar%2f..%2fblah" to requesting path "/bar/../blah"
from the FTP server, which is weird.  It now requests the file named
"bar%2f..%2fblah" instead.  Worth noting that GURL considers this to be
a separate url from ftp://foo/blah, so its best to be consistent with
that behavior.  Also, when Chrome sees an FTP file with %'s in its name,
it unescapes them, so Chrome would never generate a URL with "%2f" in
it, but they could still come from external sources.

This CL also fixes the title of directory listings of paths with "%2f"
in them - ftp://foo/bar%2f/baz will now say "Index of /bar%2f/" instead
of "Index of /bar//".

BUG=597056
==========

to

==========
Fix handling of escaped slashes ("%2f") in FTP paths.

Chrome was unescaping them before sending requests to the server, which
would map "ftp://foo/bar%2f..%2fblah" to requesting path "/bar/../blah"
from the FTP server, which is weird.  It now requests the file named
"bar%2f..%2fblah" instead.  Worth noting that GURL considers this to be
a separate url from ftp://foo/blah, so its best to be consistent with
that behavior.  Also, when Chrome sees an FTP file with %'s in its name,
it unescapes them, so Chrome would never generate a URL with "%2f" in
it, but they could still come from external sources.

This CL also fixes the title of directory listings of paths with "%2f"
in them - ftp://foo/bar%2f/baz will now say "Index of /bar%2f/" instead
of "Index of /bar//".

BUG=597056
==========

[commit-bot: I haz the power, 2016-03-23 23:06:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-23 23:08:15]

Description was changed from

==========
Fix handling of escaped slashes ("%2f") in FTP paths.

Chrome was unescaping them before sending requests to the server, which
would map "ftp://foo/bar%2f..%2fblah" to requesting path "/bar/../blah"
from the FTP server, which is weird.  It now requests the file named
"bar%2f..%2fblah" instead.  Worth noting that GURL considers this to be
a separate url from ftp://foo/blah, so its best to be consistent with
that behavior.  Also, when Chrome sees an FTP file with %'s in its name,
it unescapes them, so Chrome would never generate a URL with "%2f" in
it, but they could still come from external sources.

This CL also fixes the title of directory listings of paths with "%2f"
in them - ftp://foo/bar%2f/baz will now say "Index of /bar%2f/" instead
of "Index of /bar//".

BUG=597056
==========

to

==========
Fix handling of escaped slashes ("%2f") in FTP paths.

Chrome was unescaping them before sending requests to the server, which
would map "ftp://foo/bar%2f..%2fblah" to requesting path "/bar/../blah"
from the FTP server, which is weird.  It now requests the file named
"bar%2f..%2fblah" instead.  Worth noting that GURL considers this to be
a separate url from ftp://foo/blah, so its best to be consistent with
that behavior.  Also, when Chrome sees an FTP file with %'s in its name,
it unescapes them, so Chrome would never generate a URL with "%2f" in
it, but they could still come from external sources.

This CL also fixes the title of directory listings of paths with "%2f"
in them - ftp://foo/bar%2f/baz will now say "Index of /bar%2f/" instead
of "Index of /bar//".

BUG=597056

Committed: https://crrev.com/0a2a0e15f6741225fbce75cfc4fa07db0a00190d
Cr-Commit-Position: refs/heads/master@{#382961}
==========

[commit-bot: I haz the power, 2016-03-23 23:08:16]

Patchset 2 (id:??) landed as
https://crrev.com/0a2a0e15f6741225fbce75cfc4fa07db0a00190d
Cr-Commit-Position: refs/heads/master@{#382961}