Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java

Issue 1827883004: Synchronize native adapter access in CronetUrlRequestContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java
diff --git a/components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java b/components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java
index 5d5dc481e110f7bd4727da14789c41f83e5f27e7..f63a5ca8e221e73c0f70b014d580a4b2c6874c75 100644
--- a/components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java
+++ b/components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java
@@ -79,10 +79,12 @@ class CronetUrlRequestContext extends CronetEngine {
public CronetUrlRequestContext(CronetEngine.Builder builder) {
CronetLibraryLoader.ensureInitialized(builder.getContext(), builder);
nativeSetMinLogLevel(getLoggingLevel());
- mUrlRequestContextAdapter = nativeCreateRequestContextAdapter(
- createNativeUrlRequestContextConfig(builder.getContext(), builder));
- if (mUrlRequestContextAdapter == 0) {
- throw new NullPointerException("Context Adapter creation failed.");
+ synchronized (mLock) {
+ mUrlRequestContextAdapter = nativeCreateRequestContextAdapter(
+ createNativeUrlRequestContextConfig(builder.getContext(), builder));
+ if (mUrlRequestContextAdapter == 0) {
+ throw new NullPointerException("Context Adapter creation failed.");
+ }
}
// Init native Chromium URLRequestContext on main UI thread.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698