third_party/WebKit/Source/core/html/HTMLMediaElement.cpp - Issue 1827853002: [Android, RemotePlayback] Implement HTMLMediaElement.remote.connect().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 1827853002: [Android, RemotePlayback] Implement HTMLMediaElement.remote.connect(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remote-playback-availability

Patch Set: Fixed nooilpan build Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.h ('k') | third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h » ('j') | third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

index 6dcd96d4480275f0b01cedc35b52bcee28b1e437..a5613467714c6353a2b3f75f43d23d688d9c3a15 100644

--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

@@ -366,6 +366,9 @@ HTMLMediaElement::HTMLMediaElement(const QualifiedName& tagName, Document& docum

, m_audioSourceNode(nullptr)

, m_autoplayHelper(*this)

, m_remotePlaybackClient(nullptr)

+#if !ENABLE(OILPAN)

+ , m_weakPtrFactory(this)

+#endif

{

#if ENABLE(OILPAN)

ThreadState::current()->registerPreFinalizer(this);

@@ -3831,4 +3834,12 @@ DEFINE_TRACE(HTMLMediaElement::AudioSourceProviderImpl)

visitor->trace(m_client);

}

+#if !ENABLE(OILPAN)

+WeakPtr<HTMLMediaElement> HTMLMediaElement::createWeakPtr()

+ return m_weakPtrFactory.createWeakPtr();

+#endif

} // namespace blink