[Android, RemotePlayback] Implement HTMLMediaElement.remote.connect().

third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h

Index: third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h
diff --git a/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h b/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h
index fa24f558fc5ac27779afcac8b4549c1b52f4e452..5d82253af4c82c9e9b062527780585e6d8489ccc 100644
--- a/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h
+++ b/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h
@@ -20,6 +20,7 @@ class ExecutionContext;
 class HTMLMediaElement;
 class LocalFrame;
 class RemotePlaybackAvailability;
+class ScriptPromiseResolver;
 
 class RemotePlayback final
     : public RefCountedGarbageCollectedEventTargetWithInlineData<RemotePlayback>
@@ -31,13 +32,14 @@ class RemotePlayback final
 public:
     static RemotePlayback* create(HTMLMediaElement&);
 
-    ~RemotePlayback() override = default;
+    ~RemotePlayback() override;
 
     // EventTarget implementation.
     const WTF::AtomicString& interfaceName() const override;
     ExecutionContext* getExecutionContext() const override;
 
     ScriptPromise getAvailability(ScriptState*);
+    ScriptPromise connect(ScriptState*);
 
     String state() const;
 
@@ -46,7 +48,7 @@ public:
     DECLARE_VIRTUAL_TRACE();
 
 private:
-    RemotePlayback(LocalFrame*, WebRemotePlaybackState, bool availability);
+    explicit RemotePlayback(HTMLMediaElement&);
 
     void stateChanged(WebRemotePlaybackState) override;
     void availabilityChanged(bool available) override;
@@ -54,6 +56,8 @@ private:
     WebRemotePlaybackState m_state;
     bool m_availability;
     HeapVector<Member<RemotePlaybackAvailability>> m_availabilityObjects;
+    RefPtrWillBeMember<HTMLMediaElement> m_mediaElement;

[philipj_slow, 2016/03/29 05:51:45]

Is this now a reference cycle that will leak memory?

[whywhat, 2016/03/29 15:30:01]

In some non-existent build I guess. I gave up and added createWeakPtr() (and now
need your OWNERS approval).
Hopefully this will be cleaned up soon when *WillBe* classes will be removed and
the non-oilpan bot shut down.

+    HeapVector<Member<ScriptPromiseResolver>> m_connectPromiseResolvers;
 };
 
 } // namespace blink