Issue 1827823002: Fix win/clang part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1827823002: Fix win/clang part 2. (Closed)

Created:
4 years, 9 months ago by dsinclair

Modified:
4 years, 9 months ago

Reviewers:
Wei Li

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

Fix win/clang part 2. After moving EmbeddedUnicodeFromCharcode the IsValidEmbeddedCharcodeFromUnicodeCharset method is no longer used on windows. TBR=weili@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/13dcc976ac07fc4462261023d36789a3e5931559

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	core/fpdfapi/fpdf_font/fpdf_font_cid.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (1 generated)

dsinclair

Committed patchset #1 (id:1) manually as 13dcc976ac07fc4462261023d36789a3e5931559 (tree was closed).

4 years, 9 months ago (2016-03-23 13:44:35 UTC) #2

Message was sent while issue was closed.

lgtm