Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1827813004: [turbofan] Introduce proper abstractions for ToNumber truncations. (Closed)

Created:
4 years, 9 months ago by Benedikt Meurer
Modified:
4 years, 9 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce proper abstractions for ToNumber truncations. Introduce TruncateTaggedToFloat64 and TruncateTaggedToWord32 into the CodeStubAssembler, which encapsulates the ToNumber truncation and returns the resulting number as either Float64 or further truncated to Word32. R=jarin@chromium.org BUG=v8:4587 LOG=n Committed: https://crrev.com/1abd78979c29f74f2455961deaa1a83670cd6521 Cr-Commit-Position: refs/heads/master@{#35051}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -236 lines) Patch
M src/builtins.cc View 1 chunk +6 lines, -66 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +30 lines, -164 lines 0 comments Download
M src/compiler/code-stub-assembler.h View 3 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/code-stub-assembler.cc View 3 chunks +104 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-code-stub-assembler.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
4 years, 9 months ago (2016-03-24 05:41:15 UTC) #1
Jarin
lgtm
4 years, 9 months ago (2016-03-24 05:45:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827813004/1
4 years, 9 months ago (2016-03-24 05:45:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-24 06:05:10 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 06:06:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1abd78979c29f74f2455961deaa1a83670cd6521
Cr-Commit-Position: refs/heads/master@{#35051}

Powered by Google App Engine
This is Rietveld 408576698