Source/core/svg/SVGFontFaceElement.cpp - Issue 18278003: Introduce isSVGFontElement() and isSVGImageElement(), and use them

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGFontFaceElement.cpp

Issue 18278003: Introduce isSVGFontElement() and isSVGImageElement(), and use them (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGFontFaceElement.cpp

diff --git a/Source/core/svg/SVGFontFaceElement.cpp b/Source/core/svg/SVGFontFaceElement.cpp

index 00a07308cb7579a0356f3d2c2e6917340f3d72c3..ca09588fbaa13e90640fe4ef7823568809033ada 100644

--- a/Source/core/svg/SVGFontFaceElement.cpp

+++ b/Source/core/svg/SVGFontFaceElement.cpp

@@ -265,7 +265,7 @@ String SVGFontFaceElement::fontFamily() const

SVGFontElement* SVGFontFaceElement::associatedFontElement() const

{

ASSERT(parentNode() == m_fontElement);

- ASSERT(!parentNode() || parentNode()->hasTagName(SVGNames::fontTag));

+ ASSERT(!parentNode() || isSVGFontElement(parentNode()));

return m_fontElement;

}

@@ -284,7 +284,7 @@ void SVGFontFaceElement::rebuildFontFace()

srcElement = static_cast<SVGFontFaceSrcElement*>(child);

}

- bool describesParentFont = parentNode()->hasTagName(SVGNames::fontTag);

+ bool describesParentFont = isSVGFontElement(parentNode());

RefPtr<CSSValueList> list;

if (describesParentFont) {

« no previous file with comments | « Source/core/svg/SVGFontElement.cpp ('k') | Source/core/svg/SVGGlyphElement.cpp » ('j') | no next file with comments »