Source/core/svg/SVGAnimateMotionElement.cpp - Issue 18278003: Introduce isSVGFontElement() and isSVGImageElement(), and use them

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGAnimateMotionElement.cpp

Issue 18278003: Introduce isSVGFontElement() and isSVGImageElement(), and use them (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGAnimateMotionElement.cpp

diff --git a/Source/core/svg/SVGAnimateMotionElement.cpp b/Source/core/svg/SVGAnimateMotionElement.cpp

index 23ede7ddd4f87aedf666c735aa2088d1fa93a5e2..e00cf119d43661e4c74fd9b634ca375fc9c12979 100644

--- a/Source/core/svg/SVGAnimateMotionElement.cpp

+++ b/Source/core/svg/SVGAnimateMotionElement.cpp

@@ -29,6 +29,7 @@

#include "core/rendering/svg/RenderSVGResource.h"

#include "core/rendering/svg/SVGPathData.h"

#include "core/svg/SVGElementInstance.h"

+#include "core/svg/SVGImageElement.h"

#include "core/svg/SVGMPathElement.h"

#include "core/svg/SVGParserUtilities.h"

#include "core/svg/SVGPathElement.h"

@@ -68,7 +69,7 @@ bool SVGAnimateMotionElement::hasValidAttributeType()

if (targetElement->hasTagName(gTag)

|| targetElement->hasTagName(defsTag)

|| targetElement->hasTagName(useTag)

- || targetElement->hasTagName(SVGNames::imageTag)

+ || isSVGImageElement(targetElement)

|| targetElement->hasTagName(switchTag)

|| targetElement->hasTagName(pathTag)

|| targetElement->hasTagName(rectTag)

« no previous file with comments | « Source/core/rendering/HitTestResult.cpp ('k') | Source/core/svg/SVGElement.cpp » ('j') | no next file with comments »