Source/core/svg/SVGVKernElement.cpp - Issue 18278003: Introduce isSVGFontElement() and isSVGImageElement(), and use them

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGVKernElement.cpp

Issue 18278003: Introduce isSVGFontElement() and isSVGImageElement(), and use them (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGVKernElement.cpp

diff --git a/Source/core/svg/SVGVKernElement.cpp b/Source/core/svg/SVGVKernElement.cpp

index d78c777901ca9d19c5d2fbeb8b4ed95487e80b29..db8293eb69693de281485dda416761859f7e02f2 100644

--- a/Source/core/svg/SVGVKernElement.cpp

+++ b/Source/core/svg/SVGVKernElement.cpp

@@ -44,7 +44,7 @@ Node::InsertionNotificationRequest SVGVKernElement::insertedInto(ContainerNode*

{

if (rootParent->inDocument()) {

ContainerNode* fontNode = parentNode();

- if (fontNode && fontNode->hasTagName(SVGNames::fontTag))

+ if (fontNode && isSVGFontElement(fontNode))

toSVGFontElement(fontNode)->invalidateGlyphCache();

}

@@ -54,7 +54,7 @@ Node::InsertionNotificationRequest SVGVKernElement::insertedInto(ContainerNode*

void SVGVKernElement::removedFrom(ContainerNode* rootParent)

{

ContainerNode* fontNode = parentNode();

- if (fontNode && fontNode->hasTagName(SVGNames::fontTag))

+ if (fontNode && isSVGFontElement(fontNode))

toSVGFontElement(fontNode)->invalidateGlyphCache();

SVGElement::removedFrom(rootParent);

« no previous file with comments | « Source/core/svg/SVGLocatable.cpp ('k') | no next file » | no next file with comments »