Source/core/svg/SVGHKernElement.cpp - Issue 18278003: Introduce isSVGFontElement() and isSVGImageElement(), and use them

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGHKernElement.cpp

Issue 18278003: Introduce isSVGFontElement() and isSVGImageElement(), and use them (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGHKernElement.cpp

diff --git a/Source/core/svg/SVGHKernElement.cpp b/Source/core/svg/SVGHKernElement.cpp

index 70cec60307e22d01fff6fb4acf12b49848823c99..d1aae656563b0693a6a1f022b88c63e97c7857f7 100644

--- a/Source/core/svg/SVGHKernElement.cpp

+++ b/Source/core/svg/SVGHKernElement.cpp

@@ -44,7 +44,7 @@ PassRefPtr<SVGHKernElement> SVGHKernElement::create(const QualifiedName& tagName

Node::InsertionNotificationRequest SVGHKernElement::insertedInto(ContainerNode* rootParent)

{

ContainerNode* fontNode = parentNode();

- if (fontNode && fontNode->hasTagName(SVGNames::fontTag))

+ if (fontNode && isSVGFontElement(fontNode))

toSVGFontElement(fontNode)->invalidateGlyphCache();

return SVGElement::insertedInto(rootParent);

@@ -53,7 +53,7 @@ Node::InsertionNotificationRequest SVGHKernElement::insertedInto(ContainerNode*

void SVGHKernElement::removedFrom(ContainerNode* rootParent)

{

ContainerNode* fontNode = parentNode();

- if (fontNode && fontNode->hasTagName(SVGNames::fontTag))

+ if (fontNode && isSVGFontElement(fontNode))

toSVGFontElement(fontNode)->invalidateGlyphCache();

SVGElement::removedFrom(rootParent);

« no previous file with comments | « Source/core/svg/SVGGlyphElement.cpp ('k') | Source/core/svg/SVGImageElement.h » ('j') | no next file with comments »