third_party/WebKit/LayoutTests/svg/custom/object-current-scale.html - Issue 1827793003: Support currentScale for embedded SVG

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/custom/object-current-scale.html

Issue 1827793003: Support currentScale for embedded SVG (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/svg/custom/object-current-scale-expected.html » ('j') | third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script>

	3 if (window.testRunner)

	4 testRunner.waitUntilDone();

	5

	6 function setScale() {

	7 var obj = document.getElementById("object");
	fs 2016/03/29 11:58:51 Could use querySelector and avoid the id=... Could use querySelector and avoid the id=... Shanmuga Pandi 2016/03/31 09:04:37 Done. Show quoted text On 2016/03/29 11:58:51, fs wrote: > Could use querySelector and avoid the id=... Done.
	8 var svgdoc = obj.contentDocument;

	9 var svgroot = svgdoc.documentElement;

	10 svgroot.currentScale = 0.5;

	11 if (window.testRunner)

	12 setTimeout(function() { testRunner.notifyDone(); }, 0);
	fs 2016/03/29 11:58:51 Could you use runAfterLayoutAndPaint here instead? Could you use runAfterLayoutAndPaint here instead? (It would replace most of the scaffolding.) Shanmuga Pandi 2016/03/31 09:04:37 Done. Show quoted text On 2016/03/29 11:58:51, fs wrote: > Could you use runAfterLayoutAndPaint here instead? (It would replace most of the > scaffolding.) Done.
	13 }

	14 </script>

	15

	16 <body>

	17 <object id="object" onload="setScale()" data="resources/green-rect.svg" type ="image/svg+xml"/>
	fs 2016/03/29 11:58:51 I'd suggest that you add a "reference" (another gr I'd suggest that you add a "reference" (another green rect or so) in the local document, so that it's possible to see that changing the scale in the embedded SVG did not affect the parent document. Shanmuga Pandi 2016/03/31 09:04:37 Done. Show quoted text On 2016/03/29 11:58:51, fs wrote: > I'd suggest that you add a "reference" (another green rect or so) in the local > document, so that it's possible to see that changing the scale in the embedded > SVG did not affect the parent document. Done.
	18 </body>

OLD	NEW