third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js - Issue 1827743002: SameSite: Teach devtools about the new 'samesite' syntax.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js

Issue 1827743002: SameSite: Teach devtools about the new 'samesite' syntax. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js b/third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js

index 1bea7702ad4e362dc36dd8bd4b13037c282d4dd4..61bbfc5b8665bd7cd06ad6f7fa48157f2b7eff83 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js

@@ -258,11 +258,11 @@ WebInspector.Cookie.prototype = {

/**

- * @return {boolean}

+ * @return {string}

sameSite: function ()

{

- return "samesite" in this._attributes;

+ return this._attributes["samesite"];

/**

@@ -429,7 +429,7 @@ WebInspector.Cookies._parseProtocolCookie = function(target, protocolCookie)

if (protocolCookie["secure"])

cookie.addAttribute("secure");

if (protocolCookie["sameSite"])

- cookie.addAttribute("sameSite");

+ cookie.addAttribute("sameSite", protocolCookie["sameSite"]);

cookie.setSize(protocolCookie["size"]);

return cookie;

}