third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js - Issue 1827743002: SameSite: Teach devtools about the new 'samesite' syntax.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js

Issue 1827743002: SameSite: Teach devtools about the new 'samesite' syntax. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/cookie-resource-match.html ('k') | third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js b/third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js

index 60d5a6c311ece45fdb1e5bc5075ed4f1efcf062a..501958ac0b35ba85d4097ba2a212968fcdfb983e 100644

--- a/third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js

+++ b/third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js

@@ -51,7 +51,7 @@ WebInspector.CookiesTable = function(expandable, refreshCallback, selectedCallba

{id: "size", title: WebInspector.UIString("Size"), sortable: true, align: WebInspector.DataGrid.Align.Right, weight: 7},

{id: "httpOnly", title: WebInspector.UIString("HTTP"), sortable: true, align: WebInspector.DataGrid.Align.Center, weight: 7},

{id: "secure", title: WebInspector.UIString("Secure"), sortable: true, align: WebInspector.DataGrid.Align.Center, weight: 7},

- {id: "sameSite", title: WebInspector.UIString("Same-Site"), sortable: true, align: WebInspector.DataGrid.Align.Center, weight: 7}

+ {id: "sameSite", title: WebInspector.UIString("SameSite"), sortable: true, align: WebInspector.DataGrid.Align.Center, weight: 7}

];

if (readOnly)

@@ -261,7 +261,7 @@ WebInspector.CookiesTable.prototype = {

const checkmark = "\u2713";

data.httpOnly = (cookie.httpOnly() ? checkmark : "");

data.secure = (cookie.secure() ? checkmark : "");

- data.sameSite = (cookie.sameSite() ? checkmark : "");

+ data.sameSite = cookie.sameSite() || "";

var node = new WebInspector.DataGridNode(data);

node.cookie = cookie;