third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js - Issue 1827743002: SameSite: Teach devtools about the new 'samesite' syntax.

Unified Diff: third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js

Issue 1827743002: SameSite: Teach devtools about the new 'samesite' syntax. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: optional Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/devtools/protocol/network_handler.cc ('K') | « third_party/WebKit/LayoutTests/inspector/cookie-resource-match.html ('k') | third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js b/third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js

index 60d5a6c311ece45fdb1e5bc5075ed4f1efcf062a..4e24b3f732d41ae4a3756ebf5d87a3300a8920ce 100644

--- a/third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js

+++ b/third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js

@@ -51,7 +51,7 @@ WebInspector.CookiesTable = function(expandable, refreshCallback, selectedCallba

{id: "size", title: WebInspector.UIString("Size"), sortable: true, align: WebInspector.DataGrid.Align.Right, weight: 7},

{id: "httpOnly", title: WebInspector.UIString("HTTP"), sortable: true, align: WebInspector.DataGrid.Align.Center, weight: 7},

{id: "secure", title: WebInspector.UIString("Secure"), sortable: true, align: WebInspector.DataGrid.Align.Center, weight: 7},

- {id: "sameSite", title: WebInspector.UIString("Same-Site"), sortable: true, align: WebInspector.DataGrid.Align.Center, weight: 7}

+ {id: "sameSite", title: WebInspector.UIString("SameSite"), sortable: true, align: WebInspector.DataGrid.Align.Center, weight: 7}

];

if (readOnly)

@@ -261,7 +261,7 @@ WebInspector.CookiesTable.prototype = {

const checkmark = "\u2713";

data.httpOnly = (cookie.httpOnly() ? checkmark : "");

data.secure = (cookie.secure() ? checkmark : "");

- data.sameSite = (cookie.sameSite() ? checkmark : "");

+ data.sameSite = (cookie.sameSite() ? cookie.sameSite() : "");

dgozman 2016/04/05 17:34:53 cookie.sameSite() || ""

Mike West 2016/04/05 17:55:10 Should I change `secure` and `httpOnly` as well? I

dgozman 2016/04/05 17:58:24 I think secure and httpOnly are booleans, while sa

var node = new WebInspector.DataGridNode(data);

node.cookie = cookie;