SameSite: Teach devtools about the new 'samesite' syntax.

third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 240 matching lines @@
 
     /**
      * @return {boolean}
      */
     secure: function()
     {
         return "secure" in this._attributes;
     },
 
     /**
-     * @return {boolean}
+     * @return {string}
      */
     sameSite: function ()
     {
-        return "samesite" in this._attributes;
+        return this._attributes["samesite"];
     },
 
     /**
      * @return {boolean}
      */
     session: function()
     {
         // RFC 2965 suggests using Discard attribute to mark session cookies, but this does not seem to be widely used.
         // Check for absence of explicitly max-age or expiry date instead.
         return !("expires" in this._attributes || "max-age" in this._attributes);
@@ skipping 99 matching lines @@
 }
 
 /**
  * @enum {number}
  */
 WebInspector.Cookie.Type = {
     Request: 0,
     Response: 1
 };
 
+/**
+ * @enum {string}
+ */
+WebInspector.Cookie.SameSiteMode = {

[dgozman, 2016/04/05 17:34:53]

There should be auto-generated NetworkAgent.CookieSameSite enum with
NetworkAgent.CookieSameSite.Lax and NetworkAgent.CookieSameSite.Strict values.

Also, I don't see you using it anywhere.

[Mike West, 2016/04/05 17:55:10]

Yeah. I'll just drop this entirely. Thanks!

+    Strict: "Strict",
+    Lax: "Lax",
+};
+
 WebInspector.Cookies = {}
 
 /**
  * @param {function(!Array.<!WebInspector.Cookie>)} callback
  */
 WebInspector.Cookies.getCookiesAsync = function(callback)
 {
     var allCookies = [];
     /**
      * @param {!WebInspector.Target} target
@@ skipping 26 matching lines @@
     var cookie = new WebInspector.Cookie(target, protocolCookie.name, protocolCookie.value, null);
     cookie.addAttribute("domain", protocolCookie["domain"]);
     cookie.addAttribute("path", protocolCookie["path"]);
     cookie.addAttribute("port", protocolCookie["port"]);
     if (protocolCookie["expires"])
         cookie.addAttribute("expires", protocolCookie["expires"]);
     if (protocolCookie["httpOnly"])
         cookie.addAttribute("httpOnly");
     if (protocolCookie["secure"])
         cookie.addAttribute("secure");
-    if (protocolCookie["sameSite"])
-        cookie.addAttribute("sameSite");
+    if (protocolCookie["sameSite"] != undefined)

[dgozman, 2016/04/05 17:34:54]

Omit comparison with undefined, just |if (protocolCookie[...])|

+        cookie.addAttribute("sameSite", protocolCookie["sameSite"]);
     cookie.setSize(protocolCookie["size"]);
     return cookie;
 }
 
 /**
  * @param {!WebInspector.Cookie} cookie
  * @param {string} resourceURL
  * @return {boolean}
  */
 WebInspector.Cookies.cookieMatchesResourceURL = function(cookie, resourceURL)
@@ skipping 10 matching lines @@
  * @param {string} cookieDomain
  * @param {string} resourceDomain
  * @return {boolean}
  */
 WebInspector.Cookies.cookieDomainMatchesResourceDomain = function(cookieDomain, resourceDomain)
 {
     if (cookieDomain.charAt(0) !== '.')
         return resourceDomain === cookieDomain;
     return !!resourceDomain.match(new RegExp("^([^\\.]+\\.)*" + cookieDomain.substring(1).escapeForRegExp() + "$", "i"));
 }