SameSite: Teach devtools about the new 'samesite' syntax.

third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js

 /*
  * Copyright (C) 2009 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 33 matching lines @@
 
     var columns = [
         {id: "name", title: WebInspector.UIString("Name"), sortable: true, disclosure: expandable, sort: WebInspector.DataGrid.Order.Ascending, longText: true, weight: 24},
         {id: "value", title: WebInspector.UIString("Value"), sortable: true, longText: true, weight: 34},
         {id: "domain", title: WebInspector.UIString("Domain"), sortable: true, weight: 7},
         {id: "path", title: WebInspector.UIString("Path"), sortable: true, weight: 7},
         {id: "expires", title: WebInspector.UIString("Expires / Max-Age"), sortable: true, weight: 7},
         {id: "size", title: WebInspector.UIString("Size"), sortable: true, align: WebInspector.DataGrid.Align.Right, weight: 7},
         {id: "httpOnly", title: WebInspector.UIString("HTTP"), sortable: true, align: WebInspector.DataGrid.Align.Center, weight: 7},
         {id: "secure", title: WebInspector.UIString("Secure"), sortable: true, align: WebInspector.DataGrid.Align.Center, weight: 7},
-        {id: "sameSite", title: WebInspector.UIString("Same-Site"), sortable: true, align: WebInspector.DataGrid.Align.Center, weight: 7}
+        {id: "sameSite", title: WebInspector.UIString("SameSite"), sortable: true, align: WebInspector.DataGrid.Align.Center, weight: 7}
     ];
 
     if (readOnly)
         this._dataGrid = new WebInspector.DataGrid(columns);
     else
         this._dataGrid = new WebInspector.DataGrid(columns, undefined, this._onDeleteCookie.bind(this), refreshCallback, this._onContextMenu.bind(this));
 
     this._dataGrid.setName("cookiesTable");
     this._dataGrid.addEventListener(WebInspector.DataGrid.Events.SortingChanged, this._rebuildTable, this);
 
@@ skipping 189 matching lines @@
                 data.expires = Number.secondsToString(parseInt(cookie.maxAge(), 10));
             else if (cookie.expires())
                 data.expires = new Date(cookie.expires()).toISOString();
             else
                 data.expires = WebInspector.UIString("Session");
         }
         data.size = cookie.size();
         const checkmark = "\u2713";
         data.httpOnly = (cookie.httpOnly() ? checkmark : "");
         data.secure = (cookie.secure() ? checkmark : "");
-        data.sameSite = (cookie.sameSite() ? checkmark : "");
+        data.sameSite = (cookie.sameSite() ? cookie.sameSite() : "");

[dgozman, 2016/04/05 17:34:53]

cookie.sameSite() || ""

[Mike West, 2016/04/05 17:55:10]

Should I change `secure` and `httpOnly` as well? I only went with this format
because those were already there. :)

[dgozman, 2016/04/05 17:58:24]

I think secure and httpOnly are booleans, while sameSite is a string now. Thus
the difference.

 
         var node = new WebInspector.DataGridNode(data);
         node.cookie = cookie;
         node.selectable = true;
         return node;
     },
 
     _onDeleteCookie: function(node)
     {
         var cookie = node.cookie;
         var neighbour = node.traverseNextNode() || node.traversePreviousNode();
         if (neighbour)
             this._nextSelectedCookie = neighbour.cookie;
         cookie.remove();
         this._refresh();
     },
 
     _refresh: function()
     {
         if (this._refreshCallback)
             this._refreshCallback();
     },
 
     __proto__: WebInspector.VBox.prototype
 }