SameSite: Teach devtools about the new 'samesite' syntax.

content/browser/devtools/protocol/network_handler.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/protocol/network_handler.h"
 
 #include <stddef.h>
 
 #include "base/containers/hash_tables.h"
 #include "base/strings/stringprintf.h"
@@ skipping 216 matching lines @@
                  command_id));
   return Response::OK();
 }
 
 void NetworkHandler::SendGetCookiesResponse(
     DevToolsCommandId command_id,
     const net::CookieList& cookie_list) {
   std::vector<scoped_refptr<Cookie>> cookies;
   for (size_t i = 0; i < cookie_list.size(); ++i) {
     const net::CanonicalCookie& cookie = cookie_list[i];
-    cookies.push_back(Cookie::Create()
+    scoped_refptr<Cookie> devtools_cookie = Cookie::Create()
          ->set_name(cookie.Name())
          ->set_value(cookie.Value())
          ->set_domain(cookie.Domain())
          ->set_path(cookie.Path())
          ->set_expires(cookie.ExpiryDate().ToDoubleT() * 1000)
          ->set_size(cookie.Name().length() + cookie.Value().length())
          ->set_http_only(cookie.IsHttpOnly())
          ->set_secure(cookie.IsSecure())
-         ->set_session(!cookie.IsPersistent()));
+         ->set_session(!cookie.IsPersistent());
+
+    switch (cookie.SameSite()) {
+      case net::CookieSameSite::STRICT_MODE:
+        devtools_cookie->set_same_site("Strict");

[dgozman, 2016/04/05 17:34:53]

There should be generated constants for these (based on protocol.json enum):

(content::devtools::network::)cookie::kSameSiteStrict
(content::devtools::network::)cookie::kSameSiteLax

[Mike West, 2016/04/05 17:55:10]

Oh, great! I'll use them!

+        break;
+      case net::CookieSameSite::LAX_MODE:
+        devtools_cookie->set_same_site("Lax");
+        break;
+      case net::CookieSameSite::NO_RESTRICTION:
+        break;
+    }
+    cookies.push_back(devtools_cookie);
   }
   client_->SendGetCookiesResponse(command_id,
       GetCookiesResponse::Create()->set_cookies(cookies));
 }
 
 Response NetworkHandler::DeleteCookie(
     DevToolsCommandId command_id,
     const std::string& cookie_name,
     const std::string& url) {
   if (!host_)
@@ skipping 61 matching lines @@
     return Response::InternalError("Could not connect to view");
   WebContents* web_contents = WebContents::FromRenderFrameHost(host_);
   web_contents->GetDelegate()->ShowCertificateViewerInDevTools(
       web_contents, certificate_id);
   return Response::OK();
 }
 
 }  // namespace network
 }  // namespace devtools
 }  // namespace content