Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1827713002: [remoting android] Add padding around the no-hosts text. (Closed)

Created:
4 years, 9 months ago by Lambros
Modified:
4 years, 9 months ago
Reviewers:
jamiewalch, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[remoting android] Add padding around the no-hosts text. It now wraps the last two words of the text instead of the last word (at least on the device I tested it on). BUG=593845 Committed: https://crrev.com/b850b865c62388309ce38487806a410ca2c44480 Cr-Commit-Position: refs/heads/master@{#382873}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M remoting/android/java/res/layout/main.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Lambros
It's possible that this CL will introduce wrapping where previously it didn't wrap. However, I ...
4 years, 9 months ago (2016-03-23 01:23:33 UTC) #2
Jamie
lgtm
4 years, 9 months ago (2016-03-23 17:06:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827713002/1
4 years, 9 months ago (2016-03-23 17:12:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 17:51:32 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 17:54:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b850b865c62388309ce38487806a410ca2c44480
Cr-Commit-Position: refs/heads/master@{#382873}

Powered by Google App Engine
This is Rietveld 408576698