Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1290)

Side by Side Diff: src/arm/code-stubs-arm.cc

Issue 18277006: Bugfix: array constructor stub was missing a case (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Incorrectly commented out test code Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 7058 matching lines...) Expand 10 before | Expand all | Expand 10 after
7069 Label no_info, switch_ready; 7069 Label no_info, switch_ready;
7070 // Get the elements kind and case on that. 7070 // Get the elements kind and case on that.
7071 __ CompareRoot(r2, Heap::kUndefinedValueRootIndex); 7071 __ CompareRoot(r2, Heap::kUndefinedValueRootIndex);
7072 __ b(eq, &no_info); 7072 __ b(eq, &no_info);
7073 __ ldr(r3, FieldMemOperand(r2, Cell::kValueOffset)); 7073 __ ldr(r3, FieldMemOperand(r2, Cell::kValueOffset));
7074 7074
7075 // The type cell may have undefined in its value. 7075 // The type cell may have undefined in its value.
7076 __ CompareRoot(r3, Heap::kUndefinedValueRootIndex); 7076 __ CompareRoot(r3, Heap::kUndefinedValueRootIndex);
7077 __ b(eq, &no_info); 7077 __ b(eq, &no_info);
7078 7078
7079 // We should have an allocation site object 7079 // The type cell has either an AllocationSite or a JSFunction
7080 if (FLAG_debug_code) { 7080 __ ldr(r4, FieldMemOperand(r3, 0));
7081 __ push(r3); 7081 __ CompareRoot(r4, Heap::kAllocationSiteMapRootIndex);
7082 __ ldr(r3, FieldMemOperand(r3, 0)); 7082 __ b(ne, &no_info);
7083 __ CompareRoot(r3, Heap::kAllocationSiteMapRootIndex);
7084 __ Assert(eq, "Expected AllocationSite object in register edx");
7085 }
7086 7083
7087 __ ldr(r3, FieldMemOperand(r3, AllocationSite::kPayloadOffset)); 7084 __ ldr(r3, FieldMemOperand(r3, AllocationSite::kPayloadOffset));
7088 __ SmiUntag(r3); 7085 __ SmiUntag(r3);
7089 __ jmp(&switch_ready); 7086 __ jmp(&switch_ready);
7090 __ bind(&no_info); 7087 __ bind(&no_info);
7091 __ mov(r3, Operand(GetInitialFastElementsKind())); 7088 __ mov(r3, Operand(GetInitialFastElementsKind()));
7092 __ bind(&switch_ready); 7089 __ bind(&switch_ready);
7093 7090
7094 if (argument_count_ == ANY) { 7091 if (argument_count_ == ANY) {
7095 Label not_zero_case, not_one_case; 7092 Label not_zero_case, not_one_case;
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
7199 __ bind(&fast_elements_case); 7196 __ bind(&fast_elements_case);
7200 GenerateCase(masm, FAST_ELEMENTS); 7197 GenerateCase(masm, FAST_ELEMENTS);
7201 } 7198 }
7202 7199
7203 7200
7204 #undef __ 7201 #undef __
7205 7202
7206 } } // namespace v8::internal 7203 } } // namespace v8::internal
7207 7204
7208 #endif // V8_TARGET_ARCH_ARM 7205 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698