Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: build/config/BUILD.gn

Issue 1827683002: Add MB support for the windows analyze bot. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sheesh Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/mb/mb_config.pyl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILD.gn
diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn
index 907dff696244ee11687f243de5f0ae66c5836ae4..222385f3916ba091fa1fce71396c8eaa0f83728b 100644
--- a/build/config/BUILD.gn
+++ b/build/config/BUILD.gn
@@ -33,6 +33,11 @@ declare_args() {
# Set to true to enable dcheck in Release builds.
dcheck_always_on = false
+
+ # Normally we try to decide whether to use precompiled headers or
+ # not based on the other build arguments, but in some cases it is
+ # easiest to force them off explicitly.
+ disable_precompiled_headers = false
}
# TODO(brettw) Most of these should be removed. Instead of global feature
@@ -438,32 +443,34 @@ config("shared_library_config") {
#
# Recommend precompiled headers for targets with more than 50 .cc files.
config("precompiled_headers") {
- if (is_win && !is_official_build && !use_goma) {
- # This is a string rather than a file GN knows about. It has to match
- # exactly what's in the /FI flag below, and what might appear in the source
- # code in quotes for an #include directive.
- precompiled_header = "build/precompile.h"
+ if (!is_official_build && !use_goma && !disable_precompiled_headers) {
+ if (is_win) {
+ # This is a string rather than a file GN knows about. It has to match
+ # exactly what's in the /FI flag below, and what might appear in the
+ # source code in quotes for an #include directive.
+ precompiled_header = "build/precompile.h"
- # This is a file that GN will compile with the above header. It will be
- # implicitly added to the sources (potentially multiple times, with one
- # variant for each language used in the target).
- precompiled_source = "//build/precompile.cc"
+ # This is a file that GN will compile with the above header. It will be
+ # implicitly added to the sources (potentially multiple times, with one
+ # variant for each language used in the target).
+ precompiled_source = "//build/precompile.cc"
- # Force include the header.
- cflags = [ "/FI$precompiled_header" ]
+ # Force include the header.
+ cflags = [ "/FI$precompiled_header" ]
- # Disable warning for "this file was empty after preprocessing". This
- # error is generated only in C mode for ANSI compatibility. It conflicts
- # with precompiled headers since the source file that's "compiled" for
- # making the precompiled header is empty.
- #
- # This error doesn't happen every time. In VS2013, it seems if the .pch
- # file doesn't exist, no error will be generated (probably MS tested this
- # case but forgot the other one?). To reproduce this error, do a build,
- # then delete the precompile.c.obj file, then build again.
- cflags_c = [ "/wd4206" ]
- } else if (is_mac && !is_official_build && !use_goma) {
- precompiled_header = "build/precompile.h"
- precompiled_source = "//build/precompile.h"
+ # Disable warning for "this file was empty after preprocessing". This
+ # error is generated only in C mode for ANSI compatibility. It conflicts
+ # with precompiled headers since the source file that's "compiled" for
+ # making the precompiled header is empty.
+ #
+ # This error doesn't happen every time. In VS2013, it seems if the .pch
+ # file doesn't exist, no error will be generated (probably MS tested this
+ # case but forgot the other one?). To reproduce this error, do a build,
+ # then delete the precompile.c.obj file, then build again.
+ cflags_c = [ "/wd4206" ]
+ } else if (is_mac) {
+ precompiled_header = "build/precompile.h"
+ precompiled_source = "//build/precompile.h"
+ }
}
}
« no previous file with comments | « no previous file | tools/mb/mb_config.pyl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698