Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1827653002: Fix gerrit_util to use non None body. (Closed)

Created:
4 years, 9 months ago by tandrii(chromium)
Modified:
4 years, 9 months ago
Reviewers:
Bons, szager1
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix gerrit_util to use non None body. Gerrit requires Content-Length to be set for POST requests. httplib Python library has a bug which doesn't set Content-Length if the body is empty. Python BUGS: https://bugs.python.org/issue14721 (partial fix) https://bugs.python.org/issue23539 (full fix) The full fix only appears in 2.7.11 release changelog (technically, it's been fixed in 2.7.10 rc1, but 2.7.10 was not released): https://hg.python.org/cpython/raw-file/53d30ab403f1/Misc/NEWS R=andybons@chromium.org,szager@chromium.org BUG=579160 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299459

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gerrit_util.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
tandrii(chromium)
4 years, 9 months ago (2016-03-22 23:38:56 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827653002/1
4 years, 9 months ago (2016-03-22 23:38:59 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 23:41:30 UTC) #5
szager1
lgtm
4 years, 9 months ago (2016-03-23 02:36:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827653002/1
4 years, 9 months ago (2016-03-24 09:49:51 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 09:52:26 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299459

Powered by Google App Engine
This is Rietveld 408576698