Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1827643002: Enable LayerTreeHostTestGpuRasterDeviceSizeChanged test on win (Closed)

Created:
4 years, 9 months ago by jaydasika
Modified:
4 years, 6 months ago
Reviewers:
danakj, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable LayerTreeHostTestGpuRasterDeviceSizeChanged test on win And make it run only for multi-threaded case as it relies on pending tree. BUG=596880 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/66500aad5711bd511a41d5fdb2521fa865888911 Cr-Commit-Position: refs/heads/master@{#382736}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M cc/trees/layer_tree_host_unittest.cc View 1 3 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
jaydasika
PTAL
4 years, 9 months ago (2016-03-22 22:21:27 UTC) #3
enne (OOO)
lgtm https://codereview.chromium.org/1827643002/diff/1/cc/trees/layer_tree_host_unittest.cc File cc/trees/layer_tree_host_unittest.cc (right): https://codereview.chromium.org/1827643002/diff/1/cc/trees/layer_tree_host_unittest.cc#newcode879 cc/trees/layer_tree_host_unittest.cc:879: PostSetNeedsRedrawRectToMainThread(invalid_rect_); Can you only do this if num_draws ...
4 years, 9 months ago (2016-03-22 22:36:42 UTC) #4
enne (OOO)
lgtm https://codereview.chromium.org/1827643002/diff/1/cc/trees/layer_tree_host_unittest.cc File cc/trees/layer_tree_host_unittest.cc (right): https://codereview.chromium.org/1827643002/diff/1/cc/trees/layer_tree_host_unittest.cc#newcode879 cc/trees/layer_tree_host_unittest.cc:879: PostSetNeedsRedrawRectToMainThread(invalid_rect_); Can you only do this if num_draws ...
4 years, 9 months ago (2016-03-22 22:36:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827643002/20001
4 years, 9 months ago (2016-03-22 23:11:41 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-22 23:53:17 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 23:55:05 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66500aad5711bd511a41d5fdb2521fa865888911
Cr-Commit-Position: refs/heads/master@{#382736}

Powered by Google App Engine
This is Rietveld 408576698